Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dts-gen): fix error when running dts-gen globally #2772

Merged
merged 1 commit into from
May 22, 2024

Conversation

tuanphamcybozu
Copy link
Contributor

@tuanphamcybozu tuanphamcybozu commented May 20, 2024

Why

  • Fix error when running dts-gen globally

What

  • Set current working directory to Eslint

How to test

kintone-dts-gen --base-url <domain-name> -u <username> -p <password> --app-id <app-id> --type-name SampleFields --namespace abc.types -o sample-fields.d.ts
Check command running locally and globally successful.

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@tuanphamcybozu tuanphamcybozu requested review from a team and hung-cybo and removed request for a team May 20, 2024 03:17
@github-actions github-actions bot added the pkg: dts-gen @kintone/dts-gen label May 20, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2772.d1ite8zvzg8c5i.amplifyapp.com

@hung-cybo hung-cybo changed the title fix: fix error when running dts-gen globally fix(dts-gen): fix error when running dts-gen globally May 20, 2024
Copy link
Contributor

@hung-cybo hung-cybo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tasshi-me tasshi-me merged commit 971c876 into master May 22, 2024
18 checks passed
@tasshi-me tasshi-me deleted the fix/error-when-running-dts-gen-globally branch May 22, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: dts-gen @kintone/dts-gen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants