Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use window parameter to retrieve database #89

Open
carnager opened this issue Aug 26, 2017 · 3 comments
Open

Use window parameter to retrieve database #89

carnager opened this issue Aug 26, 2017 · 3 comments

Comments

@carnager
Copy link

mpd supports the window parameter which allows to receive chunks of the database.
This way one can bypass the buffer overflow which might happen with huge collections.

@kimtore
Copy link
Owner

kimtore commented Aug 29, 2017

Thanks, I was not aware of this. I anticipate that most users will have admin access to their MPD servers, thus this is not a prioritized issue. If you implement and test this however, I'm willing to merge it into master.

@kimtore kimtore changed the title use window parameter to retrieve database Use window parameter to retrieve database Aug 29, 2017
@carnager
Copy link
Author

carnager commented Aug 29, 2017

i cant code go at all, but here is what i have done in my perl based client: https://github.com/carnager/clerk/blob/perl/clerk#L139-L156

it's just a few lines of code. and probably should have a setting in config file to set a chunksize. You don't want chunks to be too small, because each time the database is read completely, so small chunks slow it down a lot.

@tremby
Copy link
Collaborator

tremby commented Aug 30, 2017

I have no idea how to code Go either! I encourage you to give it a shot. It's pretty fast to set up a development environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants