Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make webfeed ms-tswp compliant #28

Open
akarl10 opened this issue Feb 14, 2025 · 1 comment
Open

make webfeed ms-tswp compliant #28

akarl10 opened this issue Feb 14, 2025 · 1 comment

Comments

@akarl10
Copy link
Contributor

akarl10 commented Feb 14, 2025

there seem to be multiple violations of the spec:

https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-tswp/b308d028-b81d-438b-8d64-546c9797beda
The webfeed is supposed to be version 2.x only if the client sends an accept header containing application/x-msts-radc+xml; radc_schema_version=2.0
Only schema version 2.x allow the folder attributes.

Folder naming:
https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-tswp/58596974-442c-4ed1-8e98-388c02cb631a
the root folder is always "/" and every folder begins with that "/"

Subfolder xml node
https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-tswp/cbe33ab1-4826-48f2-a0d6-e920211bda23
The inclusion of Subfolder is only valid if ResourceCollection points to a displayfolder
Looking at
https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-tswp/b563ae90-b262-4d75-a646-0a0b063022ac
they probably mean that in that case only resources of displayfolders are in the xml response, but there exist some subfolders (that might be requested seperatly, but I did not find how that would be acomplished. Maybe they just defined how the xml should look like but did not implement it.

since in feedparser.js and also on the website there is a dependency on the subfolder element this is not going to work in a compliant webfeed (if a compliant webfeed contains subfolders, that folders will not be in the xml).
To do that you would need to enumerate every possible folder and fill that with the subfolders (probably better called something else) element in feedparser.js

@kimmknight
Copy link
Owner

Nice work! I'm surprised there's not more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants