Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check recovered password last bytes to be in expected character set #76

Closed
kimci86 opened this issue Aug 16, 2022 · 0 comments · Fixed by #101
Closed

Check recovered password last bytes to be in expected character set #76

kimci86 opened this issue Aug 16, 2022 · 0 comments · Fixed by #101
Assignees
Milestone

Comments

@kimci86
Copy link
Owner

kimci86 commented Aug 16, 2022

During password recovery, the user-provided character set is used to bruteforce the n-6 first characters. The 6 last bytes are derived from there and they can have any value not necessarily in the character set.

Example originally posted by @mindked in #69 (comment):

I tried recovery password of bkcrack with -r 14 ?a
It found the password after 12 hours of running but there is a strange character. The password didn't work

as bytes: **32 69 93 69
as text: *****iôiU

Combined with tricky encoding issues, the recovered password might be difficult to use.

An improvement would be to check if every byte of the recovered password is in the provided character set.
If they are not, the password would still be printed because it should technically be a valid password anyways, but the search would continue.

This is related to #34, #35, #55.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant