Skip to content

Commit 305cb1c

Browse files
Pooja Kulkarnidanielhb
Pooja Kulkarni
authored andcommitted
Issue #54 Move button label to i18n and include buttons in html for translation
This patch moves some of the buttons defined in js to i18n file. Also includes some buttons in html for trnaslation. Signed-off-by: Pooja Kulkarni <[email protected]>
1 parent 66e3a24 commit 305cb1c

6 files changed

+12
-10
lines changed

ui/js/src/gingers390x.storage.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ gingers390x.createActionList = function(settings) {
225225
toolbarNode = $('<div class="btn-group"></div>');
226226
toolbarNode.appendTo($("#" + container));
227227
dropHTML = ['<div class="dropdown menu-flat">',
228-
'<button id="action-dropdown-button-', container, '" class="btn btn-primary dropdown-toggle" type="button" data-toggle="dropdown">', (buttonType === 'action') ? '<span class="edit-alt"></span>Actions' : '<i class="fa fa-plus-circle"></i>Add ', '<span class="caret"></span>',
228+
'<button id="action-dropdown-button-', container, '" class="btn btn-primary dropdown-toggle" type="button" data-toggle="dropdown">', (buttonType === 'action') ? '<span class="edit-alt"></span>' + i18n['GS390XFCLN0022E'] : '<i class="fa fa-plus-circle"></i>' + i18n['GS390XFCLN0021E'], '<span class="caret"></span>',
229229
'</button>',
230230
'<ul class="dropdown-menu"></ul>',
231231
'</div>'

ui/pages/addFCPLuns.html.tmpl

+3-3
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,9 @@
5454
</div>
5555
</span>
5656
<span class="pull-right">
57-
<button id="enableLunsScan" aria-expanded="false" type="button" class="row btn btn-primary">Enable LUN Scan</button>
58-
<button id="refreshLuns" aria-expanded="false" type="button" class="row btn btn-primary"><i class="fa fa-refresh"></i>Refresh</button>
59-
<button id="addSANadapter" aria-expanded="false" type="button" class="row btn btn-primary"><i class="fa fa-plus-circle"></i>Add SAN Adapter</button>
57+
<button id="enableLunsScan" aria-expanded="false" type="button" class="row btn btn-primary">$_("Enable LUN Scan")</button>
58+
<button id="refreshLuns" aria-expanded="false" type="button" class="row btn btn-primary"><i class="fa fa-refresh"></i>$_("Refresh")</button>
59+
<button id="addSANadapter" aria-expanded="false" type="button" class="row btn btn-primary"><i class="fa fa-plus-circle"></i>$_("Add SAN Adapter")</button>
6060
</span>
6161
</div>
6262
<div id="lunscan-enabled-msg-text" class="hide" style="padding-top:20px;">

ui/pages/eckd.html.tmpl

+2-2
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@
5151
<span id='alert-modal-eckd-container' style='display: none;'></span>
5252
<div class="col-md-12">
5353
<div class="row">
54-
<button aria-expanded="false" id="eckd-enable-btn" type="submit" class="row btn btn-primary">Enable</button>
55-
<button aria-expanded="false" id="eckd-refresh-btn" type="button" class="row btn btn-primary pull-right"> <i class="fa fa-refresh"></i> Refresh</button>
54+
<button aria-expanded="false" id="eckd-enable-btn" type="submit" class="row btn btn-primary">$_("Enable")</button>
55+
<button aria-expanded="false" id="eckd-refresh-btn" type="button" class="row btn btn-primary pull-right"> <i class="fa fa-refresh"></i>$_("Refresh")</button>
5656
</div>
5757
<div class="row" id="eckd-content-container"><!--Filled by JS--></div>
5858
</div>

ui/pages/fcpsanadapter.html.tmpl

+2-2
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@
5252
<span id='alert-modal-fcpsanadapter-container' style='display: none;'></span>
5353
<div class="col-md-12">
5454
<div class="row">
55-
<button aria-expanded="false" id="fcpsan-enable-btn" type="submit" class="row btn btn-primary">Enable</button>
56-
<button id="fcpsan-refresh-btn" aria-expanded="false" type="button" class="row btn btn-primary pull-right"><i class="fa fa-refresh"></i> Refresh</button>
55+
<button aria-expanded="false" id="fcpsan-enable-btn" type="submit" class="row btn btn-primary">$_("Enable")</button>
56+
<button id="fcpsan-refresh-btn" aria-expanded="false" type="button" class="row btn btn-primary pull-right"><i class="fa fa-refresh"></i>$_("Refresh")</button>
5757
</div>
5858
<div class="row" id="fcpsan-content-container"><!--Filled by JS--></div>
5959
</div>

ui/pages/i18n.json.tmpl

+2
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,8 @@
6363
"GS390XFCLN0018E":"$_("Remote WWPN")",
6464
"GS390XFCLN0019E":"$_("Successfully added all Luns")",
6565
"GS390XFCLN0020E":"$_("Adding Luns")",
66+
"GS390XFCLN0021E":"$_("Add")",
67+
"GS390XFCLN0022E":"$_("Actions")",
6668
"GS390XFS001E": "$_("Enable")",
6769
"GS390XFS002E": "$_("Device")",
6870
"GS390XFS003E": "$_("CHPIDs")",

ui/pages/network.html.tmpl

+2-2
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@
5252
<span id='alert-modal-nw-container' style='display: none;'></span>
5353
<div class="col-md-12">
5454
<div class="row">
55-
<button aria-expanded="false" id="network-enable-btn" type="submit" class="row btn btn-primary">Enable</button>
56-
<button id="network-refresh-btn" aria-expanded="false" type="button" class="row btn btn-primary pull-right"><i class="fa fa-refresh"></i> Refresh</button>
55+
<button aria-expanded="false" id="network-enable-btn" type="submit" class="row btn btn-primary">$_("Enable")</button>
56+
<button id="network-refresh-btn" aria-expanded="false" type="button" class="row btn btn-primary pull-right"><i class="fa fa-refresh"></i>$_("Refresh")</button>
5757
</div>
5858
<div class="row" id="network-content-container"><!--Filled by JS--></div>
5959
</div>

0 commit comments

Comments
 (0)