Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Series images sometimes don't download #416

Open
giantsfan006 opened this issue Oct 17, 2024 · 15 comments
Open

[Bug] Series images sometimes don't download #416

giantsfan006 opened this issue Oct 17, 2024 · 15 comments
Assignees

Comments

@giantsfan006
Copy link

Not sure why but I'm not getting any series images dowloading. I set up pinchflat for testing and everything went as expected including getting series images. Once I finished testing I deleted everything and set it up again for the long haul but now I'm not getting any of the series images coming through.

Is there a way to force them via command line or something else I can do?

@kieraneglin
Copy link
Owner

Hey there! Thanks for the report (: - I was out of cell service for the last week and I'm just catching up on what I've missed

This appears to be an outstanding yt-dlp issue that only impacts some users. My hunch is that it's caused by one of the many experiments that YouTube runs for small subsets of its users. This is reinforced by the fact that some users see this issue for a few days and then, without changing anything, the issue goes away. Unfortunately I've never experienced the issue myself which makes troubleshooting WAY harder

That said, I've been seeing more reports of this lately so I'll leave this issue open as a reminder-to-self to track this down. At the end of the day I'm reliant on yt-dlp to fix the underlying issue but I'll check with their team to see what we can come up with!

In the meantime, something that would really help is to attach your logs. In-app you can go to Config > App Info and download them from there

@kieraneglin kieraneglin changed the title Possible to force series asset download? [Bug] Series images sometimes don't download Oct 25, 2024
@kieraneglin
Copy link
Owner

@giantsfan006 I'm trying to track this down - would you mind opening a source that's seeing this issue then clicking "Actions" > "Copy JSON" and posting that here?

@kieraneglin
Copy link
Owner

(Note for me) This is what's causing this issue: yt-dlp/yt-dlp#10090. This confirms that YouTube is A/B testing responses and it's a matter of waiting for yt-dlp to catch up

@costaht
Copy link

costaht commented Oct 25, 2024

I'm not sure if it's related, but here's my json: https://pastebin.com/vVPi8Jjq
I thought I wasn't getting my posters either, but I found out what happened.
Today I use ytdl-sub and in the process of testing pinchflat, I added one of my sources, but later I noticed that ytdl-sub and pinchflat were saving the files in the same parent folder. To remedy that, I changed my Custom Name on pinchflat to something else. That's when the problem begins.
Although the Custom Name is changed, the rest of the metadata remains the same. Pinchflat will only update series_directory, banner_filepath, fanart_filepath e poster_filepath after a Refresh Metadata, and since I'm using {{ source_custom_name }} on my path, pinchflat was still saving the files in the old path.
I guess if you trigger a Refresh Metadata everytime a source is edited, that should fix the problem.

@kieraneglin
Copy link
Owner

Thank you!

Yeah, that's definitely a bit of an issue when it comes to refreshing metadata. The problem is that many users don't want that directory to change automatically if they have a lot of files in that location already. It's hard to know what behaviour the user wants since it changes depending on the circumstance 🤷‍♂️

@kieraneglin
Copy link
Owner

I've pushed an update so it might be worth seeing if this issue persists!

@Jmanko16
Copy link

Jmanko16 commented Nov 2, 2024

I've pushed an update so it might be worth seeing if this issue persists!

I'm still getting this issue. I only get banner, otherwise no downloads. I've looks and tried with the date on and with no date and issue persists.

I can provide logs unless you have any other suggestions?

@jx24734
Copy link

jx24734 commented Nov 3, 2024

I am also seeing this issue. When I add a channel, I get the banner and then the videos but no other images (poster, fanart, etc.). I can also provide logs if needed.

@kieraneglin
Copy link
Owner

kieraneglin commented Nov 4, 2024

Thanks for the patience, all!

I've dug in deeper and I'm certain the issue is a newer manifestation of this older issue: yt-dlp/yt-dlp#10090. YouTube is constantly changing elements of it's UI behind-the-scenes and yt-dlp necessarily takes some time to catch up. I can't reproduce this issue on my end (meaning YouTube isn't testing this batch of changes on me) so I'll need some outside help!

Here's how to assist:

  1. Pick a channel (not playlist) that is experiencing this issue and copy its URL
  2. Open a console session in the Pinchflat container. This may vary depending on your setup, but if you're using the CLI the command will be something like this: docker exec -it pinchflat bash
  3. Inside that new console run this command, subbing out <CHANNEL URL HERE> for the URL copied in step 1:
yt-dlp <CHANNEL URL HERE> --skip-download --convert-thumbnails jpg --output "/tmp/image.%(ext)S" --write-all-thumbnails --playlist-items 0 --print "playlist:%(.{original_url,thumbnails})j"
  1. Copy the output of this command and paste it here so I can see it

That's it for now, but this won't tell me the full story! But depending on the result of this command I'll have a followup command to run that should get to the root of the issue.

Thanks for the help!

@brianroberg

This comment was marked as off-topic.

@kieraneglin

This comment was marked as off-topic.

@kieraneglin
Copy link
Owner

Troubleshooting output from @thimplicity here: #467 (comment)

@eeble
Copy link

eeble commented Nov 17, 2024

Here's some more output
{"original_url": "https://www.youtube.com/@MangoJellySolutions", "thumbnails": [{"url": "https://yt3.googleusercontent.com/TIFvRTLyTysm6mwmv87CSFJWAcFbjQ9K_qf77EjTp68AT0zvA8EBMQQVGb7UN2XGwW-VOiF_=w1060-fcrop64=1,00005a57ffffa5a8-k-c0xffffffff-no-nd-rj", "height": 175, "width": 1060, "preference": -10, "id": "0", "resolution": "1060x175", "filepath": "/tmp/image.0.jpg"}, {"url": "https://yt3.googleusercontent.com/TIFvRTLyTysm6mwmv87CSFJWAcFbjQ9K_qf77EjTp68AT0zvA8EBMQQVGb7UN2XGwW-VOiF_=w1138-fcrop64=1,00005a57ffffa5a8-k-c0xffffffff-no-nd-rj", "height": 188, "width": 1138, "preference": -10, "id": "1", "resolution": "1138x188", "filepath": "/tmp/image.1.jpg"}, {"url": "https://yt3.googleusercontent.com/TIFvRTLyTysm6mwmv87CSFJWAcFbjQ9K_qf77EjTp68AT0zvA8EBMQQVGb7UN2XGwW-VOiF_=w1707-fcrop64=1,00005a57ffffa5a8-k-c0xffffffff-no-nd-rj", "height": 283, "width": 1707, "preference": -10, "id": "2", "resolution": "1707x283", "filepath": "/tmp/image.2.jpg"}, {"url": "https://yt3.googleusercontent.com/TIFvRTLyTysm6mwmv87CSFJWAcFbjQ9K_qf77EjTp68AT0zvA8EBMQQVGb7UN2XGwW-VOiF_=w2120-fcrop64=1,00005a57ffffa5a8-k-c0xffffffff-no-nd-rj", "height": 351, "width": 2120, "preference": -10, "id": "3", "resolution": "2120x351", "filepath": "/tmp/image.3.jpg"}, {"url": "https://yt3.googleusercontent.com/TIFvRTLyTysm6mwmv87CSFJWAcFbjQ9K_qf77EjTp68AT0zvA8EBMQQVGb7UN2XGwW-VOiF_=w2276-fcrop64=1,00005a57ffffa5a8-k-c0xffffffff-no-nd-rj", "height": 377, "width": 2276, "preference": -10, "id": "4", "resolution": "2276x377", "filepath": "/tmp/image.4.jpg"}, {"url": "https://yt3.googleusercontent.com/TIFvRTLyTysm6mwmv87CSFJWAcFbjQ9K_qf77EjTp68AT0zvA8EBMQQVGb7UN2XGwW-VOiF_=w2560-fcrop64=1,00005a57ffffa5a8-k-c0xffffffff-no-nd-rj", "height": 424, "width": 2560, "preference": -10, "id": "5", "resolution": "2560x424", "filepath": "/tmp/image.5.jpg"}, {"url": "https://yt3.googleusercontent.com/TIFvRTLyTysm6mwmv87CSFJWAcFbjQ9K_qf77EjTp68AT0zvA8EBMQQVGb7UN2XGwW-VOiF_=s0", "id": "banner_uncropped", "preference": -5, "filepath": "/tmp/image.banner_uncropped.jpg"}, {"url": "https://yt3.googleusercontent.com/pW1BvdtObNuRhXDX96oi5KoH7caiqCs-lzxNvxZmMRrkUqAQ9cqbCrRLoX9-qQ4N2PJSuYgQx74=s900-c-k-c0x00ffffff-no-rj", "height": 900, "width": 900, "id": "7", "resolution": "900x900", "filepath": "/tmp/image.7.jpg"}, {"url": "https://yt3.googleusercontent.com/pW1BvdtObNuRhXDX96oi5KoH7caiqCs-lzxNvxZmMRrkUqAQ9cqbCrRLoX9-qQ4N2PJSuYgQx74=s0", "id": "avatar_uncropped", "preference": 1, "filepath": "/tmp/image.avatar_uncropped.jpg"}]}

@DaisyF8
Copy link

DaisyF8 commented Nov 24, 2024

I think I have something

So I did the command to download the art (in Docker console) :

root@292135ee664d:/downloads/shows# yt-dlp https://www.youtube.com/@FallowLondon --skip-download --convert-thumbnails jpg --output
 "/tmp/image.%(ext)S" --write-all-thumbnails --playlist-items 0 --print "playlist:%(.{original_url,thumbnails})j"
{"original_url": "https://www.youtube.com/@FallowLondon", "thumbnails": [{"url": "https://yt3.googleusercontent.com/4AppPwV69aaoFMAIc6IIh6DKdLsX6gwAe9Hb9xt4I0rkjFYso3CfyapuvIzFghPfQF3hylS6b60=w1060-fcrop64=1,00005a57ffffa5a8-k-c0xffffffff-no-nd-rj", "height": 175, "width": 1060, "preference": -10, "id": "0", "resolution": "1060x175", "filepath": "/tmp/image.0.jpg"}, {"url": "https://yt3.googleusercontent.com/4AppPwV69aaoFMAIc6IIh6DKdLsX6gwAe9Hb9xt4I0rkjFYso3CfyapuvIzFghPfQF3hylS6b60=w1138-fcrop64=1,00005a57ffffa5a8-k-c0xffffffff-no-nd-rj", "height": 188, "width": 1138, "preference": -10, "id": "1", "resolution": "1138x188", "filepath": "/tmp/image.1.jpg"}, {"url": "https://yt3.googleusercontent.com/4AppPwV69aaoFMAIc6IIh6DKdLsX6gwAe9Hb9xt4I0rkjFYso3CfyapuvIzFghPfQF3hylS6b60=w1707-fcrop64=1,00005a57ffffa5a8-k-c0xffffffff-no-nd-rj", "height": 283, "width": 1707, "preference": -10, "id": "2", "resolution": "1707x283", "filepath": "/tmp/image.2.jpg"}, {"url": "https://yt3.googleusercontent.com/4AppPwV69aaoFMAIc6IIh6DKdLsX6gwAe9Hb9xt4I0rkjFYso3CfyapuvIzFghPfQF3hylS6b60=w2120-fcrop64=1,00005a57ffffa5a8-k-c0xffffffff-no-nd-rj", "height": 351, "width": 2120, "preference": -10, "id": "3", "resolution": "2120x351", "filepath": "/tmp/image.3.jpg"}, {"url": "https://yt3.googleusercontent.com/4AppPwV69aaoFMAIc6IIh6DKdLsX6gwAe9Hb9xt4I0rkjFYso3CfyapuvIzFghPfQF3hylS6b60=w2276-fcrop64=1,00005a57ffffa5a8-k-c0xffffffff-no-nd-rj", "height": 377, "width": 2276, "preference": -10, "id": "4", "resolution": "2276x377", "filepath": "/tmp/image.4.jpg"}, {"url": "https://yt3.googleusercontent.com/4AppPwV69aaoFMAIc6IIh6DKdLsX6gwAe9Hb9xt4I0rkjFYso3CfyapuvIzFghPfQF3hylS6b60=w2560-fcrop64=1,00005a57ffffa5a8-k-c0xffffffff-no-nd-rj", "height": 424, "width": 2560, "preference": -10, "id": "5", "resolution": "2560x424", "filepath": "/tmp/image.5.jpg"}, {"url": "https://yt3.googleusercontent.com/4AppPwV69aaoFMAIc6IIh6DKdLsX6gwAe9Hb9xt4I0rkjFYso3CfyapuvIzFghPfQF3hylS6b60=s0", "id": "banner_uncropped", "preference": -5, "filepath": "/tmp/image.banner_uncropped.jpg"}, {"url": "https://yt3.googleusercontent.com/oi3kvSww54jIRjYw8m4wT4uzGzOU70Ihi9xjCZilv0YcKj8gG0prQIwyH5aB-kqBVghUpKWN=s900-c-k-c0x00ffffff-no-rj", "height": 900, "width": 900, "id": "7", "resolution": "900x900", "filepath": "/tmp/image.7.jpg"}, {"url": "https://yt3.googleusercontent.com/oi3kvSww54jIRjYw8m4wT4uzGzOU70Ihi9xjCZilv0YcKj8gG0prQIwyH5aB-kqBVghUpKWN=s0", "id": "avatar_uncropped", "preference": 1, "filepath": "/tmp/image.avatar_uncropped.jpg"}]} 

and the files are getting downloaded to /tmp

root@292135ee664d:/downloads/shows# ls -al /tmp
total 3292
drwxrwxrwt 1 root root     276 Nov 24 17:03 .
drwxr-xr-x 1 root root     188 Nov 24 16:15 ..
-rw-r--r-- 1 root root   57360 Nov 24 17:03 image.0.jpg
-rw-r--r-- 1 root root   64209 Nov 24 17:03 image.1.jpg
-rw-r--r-- 1 root root  109114 Nov 24 17:03 image.2.jpg
-rw-r--r-- 1 root root  135094 Nov 24 17:03 image.3.jpg
-rw-r--r-- 1 root root  135094 Nov 24 17:03 image.4.jpg
-rw-r--r-- 1 root root  135094 Nov 24 17:03 image.5.jpg
-rw-r--r-- 1 root root  148303 Nov 24 17:03 image.7.jpg
-rw-r--r-- 1 root root  104897 Nov 24 17:03 image.avatar_uncropped.jpg
-rw-r--r-- 1 root root 2468542 Nov 24 17:03 image.banner_uncropped.jpg
drwxr-xr-x 1 root root       8 Nov 24 16:15 pinchflat
root@292135ee664d:/downloads/shows# cp /tmp/* /downloads/shows/

So I can look at the art for Fallow, the command downloaded it just now.

And this is where I get lucky : I have one channel Diesel Creek that does have art from when I was testing my setup a few days ago. I was one of the first channels I set up.

Raw Attributes
Media Profile: MediaCenter

    collection_name: Diesel Creek
    fast_index: true
    fanart_filepath: /downloads/shows/DieselCreek/fanart.jpg
    uuid: bcb97e7f-f1d6-43ff-a506-b47e551ae2b9
    use_cookies: false
    poster_filepath: /downloads/shows/DieselCreek/poster.jpg
    collection_type: channel
    last_indexed_at: 2024-11-24T12:03:36Z
    retention_period_days:
    original_url: https://www.youtube.com/@DieselCreek
    description: HEAVY EQUIPMENT - CONSTRUCTION - PROPERTY MANAGEMENT - FABRICATION & REPAIR - HOMESTEADING
    updated_at: 2024-11-24T12:03:36Z
    marked_for_deletion_at:
    custom_name: DieselCreek
    index_frequency_minutes: 43200
    download_media: true
    download_cutoff_date: 2024-11-20
    max_duration_seconds:
    series_directory: /downloads/shows/DieselCreek
    collection_id: UCBB0oz7Yo_35gnbPYGKGJTA
    title_filter_regex:
    output_path_template_override:
    min_duration_seconds:
    banner_filepath: /downloads/shows/DieselCreek/banner.jpg
    media_profile_id: 3
    nfo_filepath: /downloads/shows/DieselCreek/tvshow.nfo
    id: 21
    inserted_at: 2024-11-24T11:52:25Z

as you can see Diesel Creek has paths for fanart, banner, nfo, and series_directory: /downloads/shows/DieselCreek

If I go to the test channel Fallow I see this (and I have no art)

Raw Attributes
Media Profile: MediaCenter

    collection_name: Fallow
    fast_index: false
    fanart_filepath:
    uuid: 9127960b-d779-41ae-aef6-7daf8c16a02b
    use_cookies: false
    poster_filepath:
    collection_type: channel
    last_indexed_at: 2024-11-24T15:00:26Z
    retention_period_days:
    original_url: https://www.youtube.com/@FallowLondon
    description: We're Jack and Will, & we run Fallow, Roe & FOWL restaurants in London. For enquiries, contact [email protected]
    updated_at: 2024-11-24T15:00:26Z
    marked_for_deletion_at:
    custom_name: Fallow
    index_frequency_minutes: 180
    download_media: true
    download_cutoff_date: 2024-11-20
    max_duration_seconds:
    series_directory:
    collection_id: UCJ901NqoRaXMnIm7aOjLyuA
    title_filter_regex:
    output_path_template_override:
    min_duration_seconds:
    banner_filepath:
    media_profile_id: 3
    nfo_filepath:
    id: 5
    inserted_at: 2024-11-23T22:04:53Z

All those paths are empty... And I don't think It's because the downloads failed the previous time. The fact that "series_directory" is empty seems weird. Hopefully this is related to the cause...

This is my current Media Profile

Raw Attributes

    id: 3
    name: MediaCenter
    inserted_at: 2024-11-24T10:55:30Z
    updated_at: 2024-11-24T14:52:03Z
    download_nfo: true
    output_path_template: /shows/{{ source_custom_name }}/{{ season_by_year__episode_by_date_and_index }} - {{ title }}.{{ ext }}
    media_container:
    preferred_resolution: 1080p
    sponsorblock_categories:
    sponsorblock_behaviour: disabled
    download_thumbnail: true
    embed_thumbnail: false
    download_auto_subs: true
    download_subs: true
    embed_subs: false
    sub_langs: en
    download_metadata: false
    embed_metadata: true
    marked_for_deletion_at:
    download_source_images: true
    livestream_behaviour: exclude
    redownload_delay_days: 1
    shorts_behaviour: exclude

Output path is default

output_path_template: /shows/{{ source_custom_name }}/{{ season_by_year__episode_by_date_and_index }} - {{ title }}.{{ ext }}

Is it a clue ?

@DaisyF8
Copy link

DaisyF8 commented Nov 24, 2024

Okay weird because I could swear I did this before but I'm doing "Refresh Metadata" for all my sources and everything is getting updated and I have art.

`
Raw Attributes
Media Profile: MediaCenter

collection_name: Fallow
fast_index: false
fanart_filepath: /downloads/shows/Fallow/fanart.jpg
uuid: 9127960b-d779-41ae-aef6-7daf8c16a02b
use_cookies: false
poster_filepath: /downloads/shows/Fallow/poster.jpg
collection_type: channel
last_indexed_at: 2024-11-24T15:00:26Z
retention_period_days:
original_url: https://www.youtube.com/@FallowLondon
description: We're Jack and Will, & we run Fallow, Roe & FOWL restaurants in London. For enquiries, contact [email protected]
updated_at: 2024-11-24T16:45:54Z
marked_for_deletion_at:
custom_name: Fallow
index_frequency_minutes: 180
download_media: true
download_cutoff_date: 2024-11-20
max_duration_seconds:
series_directory: /downloads/shows/Fallow
collection_id: UCJ901NqoRaXMnIm7aOjLyuA
title_filter_regex:
output_path_template_override:
min_duration_seconds:
banner_filepath: /downloads/shows/Fallow/banner.jpg
media_profile_id: 3
nfo_filepath: /downloads/shows/Fallow/tvshow.nfo
id: 5
inserted_at: 2024-11-23T22:04:53Z

`

My timezone is 1 hour difference so "updated at" was just now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants