Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

SWS-104 Adds travis testing #24

Merged
merged 1 commit into from
Feb 19, 2018
Merged

SWS-104 Adds travis testing #24

merged 1 commit into from
Feb 19, 2018

Conversation

josejulio
Copy link
Contributor

@josejulio
Copy link
Contributor Author

Testing on my own fork yields the following error/warnings/notes that might need further review:

  • Failed to load tsconfig.json: Missing baseUrl in compilerOptions
  • Found no baseUrl in tsconfig.json, not applying tsconfig-paths-webpack-plugin
  • The project was built assuming it is hosted at /mtho11/swsui/.
    You can control this with the homepage field in your package.json.

@mtho11
Copy link
Contributor

mtho11 commented Feb 19, 2018

I fixed the last issue with #26
The first two issues don't stop the compiling and can be addressed as a separate PR.

@josejulio josejulio closed this Feb 19, 2018
@josejulio josejulio reopened this Feb 19, 2018
@josejulio
Copy link
Contributor Author

I closed/opened this to kindly let travis know that he should run the tests.

Copy link
Contributor

@mtho11 mtho11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The minor compile warning can be fixed later.

@mtho11 mtho11 merged commit 2e06bdd into kiali:master Feb 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants