Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Support for remote image urls #6

Open
vsmart opened this issue Aug 24, 2017 · 3 comments
Open

[feature request] Support for remote image urls #6

vsmart opened this issue Aug 24, 2017 · 3 comments

Comments

@vsmart
Copy link

vsmart commented Aug 24, 2017

Hi @khrome,

thanks for this great library! ✨

It would be great if the image api would support accepting remote urls additionally to local filepaths.

Cheers
@vsmart

@khrome
Copy link
Owner

khrome commented Mar 3, 2018

Sorry, for the late reply... but I'm considering implementing this. Is this the library (node&browser) or on the command-line?

@khrome
Copy link
Owner

khrome commented Apr 16, 2021

This will be coming in the next release, but it will require either setting some path vars or some config options to point it at the right library. (request, axios and fetch will be one-liners). Additionally, all plugins will share this lib which uses the same interface internally regardless of what implementation is used.

@khrome
Copy link
Owner

khrome commented May 17, 2021

This is now supported on the new CLI ( ascii-art-cl ) or if you call setRequest() on the root export or on Artwork or Image directly, using a request signature compatible library (like request, postman-request, fetch-as-request, request-as-request and more).

This means it's not enabled by default (except on command line) and thus has no security implications when included in your own libs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants