Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A probability of segmentation fault #129

Open
kazachkovaanna opened this issue Jan 13, 2019 · 3 comments
Open

A probability of segmentation fault #129

kazachkovaanna opened this issue Jan 13, 2019 · 3 comments

Comments

@kazachkovaanna
Copy link

atomic_ptr * release_tower()
{
atomic_ptr * pTower = m_arrNext;
m_arrNext = nullptr;
m_nHeight = 1;
return pTower;
}

Afrter m_arrNext = nullptr and before m_nHeight = 1 call of method next(uint nLevel) will cause segmentation fault. This to lines should be in reverse order

@kazachkovaanna
Copy link
Author

@eugenyk please be aware we raised this issue

@eugenyk
Copy link
Contributor

eugenyk commented Jan 15, 2019

@kazachkovaanna, in case of pull request with bugfix and stress or unit test, which show the bug, your brigade will be awarded an excellent mark on exam

@eugenyk
Copy link
Contributor

eugenyk commented Jan 15, 2019

And a piece of advice: issue title should be more special, in your case now all segmentation faults in whole library can be addressed to your issue by name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants