refactor: 예외 처리 방식 개선 완료 #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limehee
requested review from
gwansikk,
mingmingmon,
SongJaeHoonn and
Copilot
Closed
There was a problem hiding this comment.
Copilot reviewed 246 out of 261 changed files in this pull request and generated no comments.
Files not reviewed (15)
- src/main/java/page/clab/api/domain/activity/activitygroup/exception/DuplicateAbsentExcuseException.java: Evaluated as low risk
- src/main/java/page/clab/api/domain/activity/activitygroup/exception/AlreadyAppliedException.java: Evaluated as low risk
- src/main/java/page/clab/api/domain/activity/activitygroup/exception/AlreadySubmittedThisWeekAssignmentException.java: Evaluated as low risk
- src/main/java/page/clab/api/domain/activity/activitygroup/exception/ActivityGroupNotProgressingException.java: Evaluated as low risk
- src/main/java/page/clab/api/domain/activity/activitygroup/exception/DuplicateAttendanceException.java: Evaluated as low risk
- src/main/java/page/clab/api/domain/activity/activitygroup/exception/ActivityGroupNotFinishedException.java: Evaluated as low risk
- src/main/java/page/clab/api/domain/activity/activitygroup/exception/AssignmentBoardHasNoDueDateTimeException.java: Evaluated as low risk
- src/main/java/page/clab/api/domain/activity/activitygroup/api/ActivityGroupMemberController.java: Evaluated as low risk
- src/main/java/page/clab/api/domain/activity/activitygroup/api/ActivityGroupBoardController.java: Evaluated as low risk
- src/main/java/page/clab/api/domain/activity/activitygroup/api/AttendanceController.java: Evaluated as low risk
- src/main/java/page/clab/api/domain/activity/activitygroup/api/ActivityGroupAdminController.java: Evaluated as low risk
- src/main/java/page/clab/api/domain/activity/activitygroup/api/ActivityGroupReportController.java: Evaluated as low risk
- src/main/java/page/clab/api/domain/activity/activitygroup/application/AttendanceService.java: Evaluated as low risk
- src/main/java/page/clab/api/domain/activity/activitygroup/application/ActivityGroupReportService.java: Evaluated as low risk
- src/main/java/page/clab/api/domain/activity/activitygroup/domain/ActivityGroupBoard.java: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/main/java/page/clab/api/domain/activity/activitygroup/application/ActivityGroupAdminService.java:297
- The error message for ErrorCode.INVALID_ROLE_CHANGE should be more descriptive. Suggestion: "Cannot change the member's role to none."
throw new BaseException(ErrorCode.INVALID_ROLE_CHANGE, "직책이 없는 멤버로 변경할 수 없습니다.");
gwansikk
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
중앙 집중식 예외 관리 체계를 구축하기 위해
BaseException과ErrorCode를 활용하도록 개선하였습니다. 이를 통해 클라이언트가ErrorCode이름을 통해 오류를 쉽게 이해하고 처리할 수 있도록 지원합니다.Tasks
BaseException및ErrorCode를 기반으로 중앙 집중식 예외 관리 구현GlobalExceptionHandler에서 발생하는 모든 예외를ErrorCode와 매핑하여 처리하도록 수정ETC