refactor : 이달의 생일자 조회 시 관리자와 게스트 정보 제외 완료 #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
1 task
1 task
SongJaeHoonn
requested changes
Jan 20, 2025
...ge/clab/api/domain/memberManagement/member/adapter/out/persistence/MemberRepositoryImpl.java
Outdated
Show resolved
Hide resolved
limehee
reviewed
Jan 21, 2025
...ge/clab/api/domain/memberManagement/member/adapter/out/persistence/MemberRepositoryImpl.java
Show resolved
Hide resolved
limehee
approved these changes
Jan 21, 2025
...ge/clab/api/domain/memberManagement/member/adapter/out/persistence/MemberRepositoryImpl.java
Show resolved
Hide resolved
SongJaeHoonn
approved these changes
Jan 23, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#665
이달의 생일자 조회 시 관리자와 게스트 정보는 제외하도록 where 구문을 수정했습니다.
Tasks
ETC
실제 서버의 data를 dump 하여 테스트를 진행했습니다.
원래는 아래처럼 관리자와 방문자가 맨 앞에 조회 되었으나 Screenshot에 첨부된 JSON 응답 처럼 실제 멤버부터 조회되는 것을 확인 할 수 있습니다.
Screenshot