-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 코드 설명을 위한 주석 및 JavaDocs 추가 완료 #605
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingmingmon
reviewed
Nov 1, 2024
.../java/page/clab/api/domain/activity/activitygroup/application/ActivityGroupAdminService.java
Show resolved
Hide resolved
limehee
reviewed
Nov 1, 2024
.../java/page/clab/api/domain/activity/activitygroup/application/ActivityGroupAdminService.java
Show resolved
Hide resolved
.../java/page/clab/api/domain/activity/activitygroup/application/ActivityGroupAdminService.java
Outdated
Show resolved
Hide resolved
mingmingmon
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했습니다! 👍👍
limehee
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@code
와 @link
같은 주석 어노테이션을 적절히 활용해, 한눈에 이해하기 쉽게 정리해주신 부분이 인상 깊네요. 코드베이스 전반을 꼼꼼하게 검토하며 주석을 작성하시느라 고생 많으셨습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
프로젝트 규모가 커짐에 따라 전 도메인 이해가 어려워지고 있으며, 신규 팀원의 빠른 적응을 위해 기본 CRUD를 제외한 복잡도 있는 메소드에 대해 JavaDocs와 주석이 필요했습니다.
또한, 시간이 지나면서 레거시가 될 가능성이 큰 만큼, 작업 의도나 도메인 규칙을 쉽게 파악할 수 있어야 했기에 Application 레이어의 메소드, 그리고 Filter, Util 클래스 등 핵심적이고 공통으로 사용되는 클래스에 JavaDocs 또는 주석을 작성했습니다.
Tasks
ETC
커밋을 보면,
//
주석을 달아 둔 부분과 JavaDocs를 사용한 부분이 있습니다.//
주석을 달아둔 부분JavaDocs
를 사용한 부분Filter
및Util
클래스