-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 이메일 템플릿 하드코딩 개선 및 외부 관리로 전환 완료 #580
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
SongJaeHoonn
reviewed
Oct 1, 2024
src/main/java/page/clab/api/global/common/email/application/EmailService.java
Show resolved
Hide resolved
SongJaeHoonn
approved these changes
Oct 1, 2024
@SongJaeHoonn 이메일을 전송하는 메소드에 공통으로 적용되는 로직을 별도의 메소드로 추출했어요. 재검토 부탁드립니다! |
mingmingmon
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인 완료했습니다! 상황별로 템플릿 사용이 가능해질 것 같네요 👍👍
코드가 더 깔끔해졌네요! 수고하셨습니다 |
SongJaeHoonn
approved these changes
Oct 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
기존의 하드코딩된 이메일 내용을 YAML 파일로 이동하고, 비밀번호 재설정 관련 메일 전송 메소드를 개선했습니다. 이메일 템플릿 관리의 유연성을 높이고 코드에서 템플릿 변경 없이 YAML에서 쉽게 수정할 수 있도록 개선하였습니다.
Tasks
new-password
템플릿을 추가EmailService
의 템플릿 로직을EmailTemplateProperties
를 사용하여 동적으로 이메일 내용을 불러오도록 리팩토링추가된 YAML
ETC
Screenshot