-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admin interface isn't styled #2325
Comments
Missed out a part of my stacktrace: |
Possible duplicate: keystonejs/keystone#1295 Except my problem is consistent. |
I had to downgrade to v5.6.0, dunno yet why 5.7.0 is causing this |
anything here jump out? https://nodejs.org/en/blog/release/v5.7.0/ |
I think its related to this change in Node 5.7.0 I've "fixed" it on keystone code itself, but i dont even know if my fix will work on a fixed Node post 5.7.0 |
My admin broke after updating nodemon, the /js and /styles routes were not being handled properly and If I had auth turned off I was getting ReferenceErrors because keystone was treating them as lists. With auth on, they were giving 302s and I couldn't login. I discovered nodemon had updated node to 5.7.0, so downgraded it to 5.6.0. At that point things seemed to be served but the admin was just giving a blank screen, no errors anywhere. I removed nodemon and that fixed it. |
[email protected] has been released but my issue still exists. However nodejs/node#5383 has been fixed. |
I really think we should restrict support to LTS, no @JedWatson? |
I think it would be a real shame to limit support to LTS. I think it will also bit a bit harsh to do retrospectively. I would guess quite a lot are on 5.x, using some of the newer language features, and if they cannot upgrade to the latest version of 5.x on the security update, then they will be a though position. |
I'm not particularly keen to limit support to LTS either, we're using 5.6 for a new project too :) Not sure that not supporting new versions of node is a good solution (if we added something that breaks w/ an older version of node, that's another issue, ideally going forward we'll maintain versions for compatibility with LTS releases) The other issue is it's not friendly to newcomers who'll install the latest node and expect Keystone to work. I think requiring older node versions would be a bit antagonistic to community growth, which is the opposite of what we want! Kind of challenging though in the sense that I'm focused on getting our internals cleaned up for the new API to go live and finally hitting a 0.4 release of Keystone. This is a pain. @jacargentina what was your fix? |
Guys, I got this and I'm new to Keystone and developing general and while I think this discussion is very interesting, I'm here to know how to fix the issue today. Is there a work around? Can I fix it on my end or do I have to wait for another release of either Nodejs or KSjs and if so, which one should I wait for? Please and thank you! PS./FYI. I'm a Free Code Camper guy btw and so I think I'd represent a type that may try Keystone, so feel free if you like to message and ask me stuff in the future is all I'm saying if you think there is value in my user demographic. |
@pythonlabsstudent, you just need to use Node <= 5.6.0 for now |
@JedWatson Remember the "path changes" you pointed on my PR for lodash migration? Its already fixed there There is a regression on NodeJS 5.7.0 path module: the path on line 51 was: router.use('/styles', less(path.resolve(__dirname + '../../../public/styles'), lessOptions)); resolved to something like
Note how the path concatenates the app part with .. I've simply found that the real path to be resolved should be:
Then removed the initial .. from there! And everything started working on my setup. |
So actually @pythonlabsstudent it should work if you use the latest code in keystone's |
@JedWatson I've just tested this - can confirm that this is fixed in the |
Great, thanks @okjake! this looks good to close now. If anyone is still having issues let me know. |
Hi @JedWatson, I am another person who is new to Keystone and faced this issue. I am using yeoman generator to create a project, and the issue is still there even if I create one from scratch. It works with node 5.6.0 but not with the latest one. How should I go about updating my Keystone installation from the latest master branch? Is there any documentation on Keystone updates in general? |
Since there wasn't a version bump on npm is |
For npm use |
Thank you, @snowkeeper, that helped! |
Can I ask to someone put simple step-by-step instruction how to install it ? Still struggling to get it right. I assume there is some issue with sequence of my steps. Initially I installed it with yeoman generator. However I executed @kat-liger you mentioned that it worked for you can you please maybe put sequence of steps you have executed. I just want to make sure I run it correctly. Already spend too much time on this and I need to get going. Thank you in advance. |
@andrejp, the command referenced above was literally all I had to run. After you created a project with "yo keystone", try running "npm i keystonejs/keystone" and then "npm install". Hope it helps! |
@kat-liger Thank you very much for your clarification. I have finally made it work. First I |
Keystone:
0.3.16
Node:
5.7.0
Platform: Windows 10
I created my project via the generator so, uh, yeah. I haven't tested this on OS X yet.
The text was updated successfully, but these errors were encountered: