F-Droid build failed

[linsui]

Developer TODO (don't remove)

• create new branch. put issue number at start of name if not a very quick fix.
• write tests. put issue number in comment
• update documentation
• squash and merge
• delete branch

> Task :app:lintVitalRelease FAILED
/home/vagrant/build/io.github.sds100.keymapper/app/src/main/res/values-cs/strings.xml:452: Error: "title_pref_devices_to_reroute_keyevents" is translated here but not found in default locale [ExtraTranslation]
    <string name="title_pref_devices_to_reroute_keyevents">Řešení pro chybu v Androidu 11, která nastaví id zařízení pro vstupní události na -1</string>
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/vagrant/build/io.github.sds100.keymapper/app/src/main/res/values-cs/strings.xml:453: Error: "summary_pref_devices_to_reroute_keyevents" is translated here but not found in default locale [ExtraTranslation]
    <string name="summary_pref_devices_to_reroute_keyevents">Vyberte zařízení, která klíčová mapa by měla zachytit všechny klíčové události a poté přesměrovat zvolenou klávesovou mapu. MUSÍTE používat klávesovou mapu GUI nebo základní vstupní metodu klávesové mapy, aby to fungovalo. Toto je částečné řešení pro https://issuetracker.google.com/issues/163120692. Toto nebude fungovat s herními ovladači.</string>
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/vagrant/build/io.github.sds100.keymapper/app/src/main/res/values-pl/strings.xml:455: Error: "title_pref_devices_to_reroute_keyevents" is translated here but not found in default locale [ExtraTranslation]
    <string name="title_pref_devices_to_reroute_keyevents">Obejście błędu Androida 11, który ustawia identyfikator urządzenia dla zdarzeń wejściowych na -1</string>
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/vagrant/build/io.github.sds100.keymapper/app/src/main/res/values-pl/strings.xml:456: Error: "summary_pref_devices_to_reroute_keyevents" is translated here but not found in default locale [ExtraTranslation]
    <string name="summary_pref_devices_to_reroute_keyevents">Obejście błędu Androida 11, który ustawia identyfikator urządzenia dla zdarzeń wejściowych na -1</string>
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

   Explanation for issues of type "ExtraTranslation":
   If a string appears in a specific language translation file, but there is
   no corresponding string in the default locale, then this string is probably
   unused. (It's technically possible that your application is only intended
   to run in a specific locale, but it's still a good idea to provide a
   fallback.)

   Note that these strings can lead to crashes if the string is looked up on
   any locale not providing a translation, so it's important to clean them
   up.

4 errors, 0 warnings
Lint found fatal errors while assembling a release target.

To proceed, either fix the issues identified by lint, or modify your build script as follows:
...
android {
    lintOptions {
        checkReleaseBuilds false
        // Or, if you prefer, you can continue to check for errors in release builds,
        // but continue the build even when errors are found:
        abortOnError false
    }
}
...

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:lintVitalRelease'.
> A failure occurred while executing com.android.build.gradle.internal.lint.AndroidLintTask$AndroidLintLauncherWorkAction
   > There was a failure while executing work items
      > A failure occurred while executing com.android.build.gradle.internal.lint.AndroidLintWorkAction
         > Lint found fatal errors while assembling a release target.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/7.0.2/userguide/command_line_interface.html#sec:command_line_warnings

Could you please take a look? Thanks!

[IzzySoft]

Apart from that, update checks fail as well because

        versionCode versionProperties.getProperty("VERSION_CODE").toInteger()
        versionName versionProperties.getProperty("VERSION_NAME")

We need literal values for that. Else:

fdroidserver.exception.FDroidException: Couldn't find any version information

I've disabled update check for now.

[linsui]

@IzzySoft I thought the correct repo is https://github.com/keymapperorg/KeyMapperKeyboard

[IzzySoft]

@linsui the old repo URL from our YAML redirected here.

[linsui]

https://github.com/sds100/KeyMapperKeyboard redirects me to that repo now. Maybe it was a mistake? Anyway I'll fix it.

[sds100]

https://github.com/sds100/KeyMapperKeyboard redirects me to that repo now. Maybe it was a mistake? Anyway I'll fix it.

Hi, I've moved all the Key Mapper repos to a keymapperorg GitHub organization. All the old github.com/sds100/* will redirect to the new github.com/keymapperorg/* repos.

[sds100]

Apart from that, update checks fail as well because

        versionCode versionProperties.getProperty("VERSION_CODE").toInteger()
        versionName versionProperties.getProperty("VERSION_NAME")

We need literal values for that. Else:

fdroidserver.exception.FDroidException: Couldn't find any version information

I've disabled update check for now.

Don't we use the git tag update check so that shouldn't be an issue?

[sds100]

I've fixed the localization error now. Will be releasing 2.3.3 now

[IzzySoft]

Don't we use the git tag update check so that shouldn't be an issue?

Yes and no. CheckUpdates then takes a look at the build.gradle to determine if the versionCode has been increased (otherwise the tag will be ignored as we already have that version). It does just a simple RegExp check, it cannot "run" the gradle. So it needs literal values – function calls or variables won't work.

[sds100]

Oh right, is there not a way to read the values from the version.properties file?

[linsui]

There is and it's what we are doing. See https://gitlab.com/fdroid/fdroiddata/-/blob/master/metadata/io.github.sds100.keymapper.yml#L164

[sds100]

Oh okay, cool! Do I need to do anything more on my end?

[linsui]

When the new version is released it eill be updated automatic. Thanks!

[sds100]

@linsui It still isn't building right?

[linsui]

It builds fine, thanks!