Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(web): TypeError: Cannot redefine property: name #9443

Closed
sentry-io bot opened this issue Aug 9, 2023 · 4 comments · Fixed by #9943
Closed

bug(web): TypeError: Cannot redefine property: name #9443

sentry-io bot opened this issue Aug 9, 2023 · 4 comments · Fixed by #9943
Assignees
Milestone

Comments

@sentry-io
Copy link

sentry-io bot commented Aug 9, 2023

Sentry Issue: KEYMAN-WEB-DX

TypeError: Cannot redefine property: name
  at None (blob:null/4baa49ce-2d04-4277-8a76-d240ad93546e:1:69)

It's clearly coming from the predictive-text worker, but... it's not clear at all which part of the worker. Sentry's information here is pretty sparse.

@jahorton jahorton added this to the A17S20 milestone Aug 9, 2023
@jahorton
Copy link
Contributor

jahorton commented Aug 9, 2023

This surfaces as a general keyboard-related error within the Android app whenever it starts up.

@jahorton
Copy link
Contributor

jahorton commented Aug 9, 2023

Note: #9409 passed its user tests just a few nightlies ago, and it would surface with the same issue. So... something must have changed somehow since then?

The first thing to come to mind: we did just merge the kmc-kmw feature branch (🗜) a few days ago with #8954. According to the bot, that'd have been 17.0.156... the currently-known minimum version for this new underlying error detected by Sentry. Not that I see an easy explanation along that route; there aren't many KMW-related files in that changeset, and none have an obvious correlation. The most significant KMW-related changes are to automated test setup... which is a far cry from what ends up in the Android app.

@jahorton
Copy link
Contributor

jahorton commented Aug 9, 2023

Using downloads.keyman.com and emulated Android 5.0, I can reproduce the error back to 17.0.154. (Before that, #9409's error is in place.) So it's nothing to do with kmc-kmw, at least.

@jahorton
Copy link
Contributor

Will be fixed by #9943.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants