Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Popup key refactor - use KMW's instead #2302

Closed
jahorton opened this issue Nov 7, 2019 · 4 comments
Closed

[iOS] Popup key refactor - use KMW's instead #2302

jahorton opened this issue Nov 7, 2019 · 4 comments
Labels
Milestone

Comments

@jahorton
Copy link
Contributor

jahorton commented Nov 7, 2019

Describe the solution you'd like
Now that we display the keyboard banner within KMW-space in the iOS app keyboard, the main reason for implementing the popup keys within iOS code is now gone. As stated by @mcdurdin in a discussion in other channels...

Another thing to refactor - we should now use the web popup rather than the iOS one for future versions, given it is now always entirely within the web frame! Will both simplify the design and allow for better control of the popups, e.g. styling etc, at least on iOS.

Product context

  • OS: iOS

Other notes
Since the current behavior is part of the general "embedded" KMW package, this would likely require some tweaks to Android popup keys, too.

@jahorton jahorton added this to the Future milestone Nov 7, 2019
@mcdurdin
Copy link
Member

mcdurdin commented Nov 7, 2019

Since the current behavior is part of the general "embedded" KMW package, this would likely require some tweaks to Android popup keys, too.

Worth noting that on Android, popup keys can encroach on the app's surface area -- unlike iOS, where they have to stay within the keyboard window.

@jahorton
Copy link
Contributor Author

jahorton commented Nov 7, 2019

Hard for web-based popup keys to display outside the WebView that hosts them, though. Or would we keep Android's version on the Java side if we did this?

@mcdurdin
Copy link
Member

mcdurdin commented Nov 7, 2019

Or would we keep Android's version on the Java side if we did this?

Yes, I am suggesting we don't apply this change to Android, at least without serious consideration of the pros and cons. :)

@jahorton jahorton modified the milestones: Future, B14S2 Dec 23, 2020
@jahorton
Copy link
Contributor Author

... looks like we forgot to close this issue off long ago. We had to move this up when iOS 13.4 released due to a change in how WKWebViews interacted with longpress gestures that broke the old approach entirely. See #2968.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants