Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(android): swapping keyboards via picker in landscape results in poor kbd layout #10241

Closed
jahorton opened this issue Dec 13, 2023 · 8 comments · Fixed by #10373 or #10442
Closed

bug(android): swapping keyboards via picker in landscape results in poor kbd layout #10241

jahorton opened this issue Dec 13, 2023 · 8 comments · Fixed by #10373 or #10442
Assignees
Milestone

Comments

@jahorton
Copy link
Contributor

From user-testing of #7324:

  • TEST_REGRESSION_ANDROID_KBD (FAILED): Retested with the attached PR build (Keyman 17.0.227-alpha-test-7324 in the Android Mobile device (ver 13) and here is my observation: 1. While testing TEST_INAPP_LATIN_KEYBOARD_LANDSCAPE test in the lanscape mode the OSK shrinks it width after using the globe key. Here, What I did is :
  1. In the Landscape mode, typed some letter using the OSK.
  2. Used Backspace and Enter button after typing each words.
  3. Clicked the globe key.
  4. Selected the same keyboard from the Picker menu.

Here, I noticed that the OSK shrinks its width on the Keyman home page. Seems to be an issue.

Originally posted by @bharanidharanj in #7324 (comment)

I have reproduced this on master - thus it is not a feature-gestures issue. There's a chance this is related to recent ✨ Android optimizations.

Of note: simply tapping the globe-key to swap keyboards does not cause the issue. Using the picker menu causes it.

@jahorton
Copy link
Contributor Author

May be related to #10054.

@darcywong00 darcywong00 added this to the A17S30 milestone Dec 20, 2023
@darcywong00
Copy link
Contributor

Will re-assign when we get to that sprint

@darcywong00
Copy link
Contributor

Re-opening due to @bharanidharanj 's user testing fail on
#10393 (comment)

@darcywong00
Copy link
Contributor

I've debugged the issue to MainActivity.onResume()

Configuration newConfig = this.getResources().getConfiguration();
if (newConfig != null && newConfig.orientation != lastOrientation) {
lastOrientation = newConfig.orientation;
KMManager.onConfigurationChanged(newConfig);
}

Sometimes after rotating from Portrait to Landscape orientation, newOrientation incorrectly reports Portrait orientation. So the app resumes with Portrait OSK dimensions.

@mcdurdin
Copy link
Member

mcdurdin commented Jan 24, 2024

Sometimes after rotating from Portrait to Landscape orientation, newOrientation incorrectly reports Portrait orientation. So the app resumes with Portrait OSK dimensions.

Is there any public reference to this issue?

@darcywong00
Copy link
Contributor

Is there any public reference to this issue?

Hmm, I've seen

I haven't found recent reports.

@mcdurdin
Copy link
Member

snap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants