Merge pull request #12227 from keymanapp/fix/android/mirror-arrows

fix(android): Auto-mirror back and forward arrows for RTL support 📟

Author: darcywong00

Diff for: android/KMAPro/kMAPro/src/main/java/com/tavultesoft/kmapro/KeyboardSettingsActivity.java

@@ -105,7 +105,7 @@ public void onCreate(Bundle savedInstanceState) {
     hashMap = new HashMap<>();
     final String customHelpLink = kbd.getHelpLink();
     // Check if app declared FileProvider
-    icon = String.valueOf(R.drawable.ic_arrow_forward);
+    icon = String.valueOf(R.drawable.ic_action_forward);
     // Don't show help link arrow if File Provider unavailable, or custom help doesn't exist
     if ( (customHelpLink != null && !FileProviderUtils.exists(context)) ||
          (customHelpLink == null && !packageID.equals(KMManager.KMDefault_UndefinedPackageID)) ) {

Diff for: android/KMAPro/kMAPro/src/main/java/com/tavultesoft/kmapro/LanguageSettingsActivity.java

@@ -174,7 +174,7 @@ public void onCreate(Bundle savedInstanceState) {
     updateActiveLexicalModel();
 
     ImageView imageView = (ImageView) layout.findViewById(R.id.image1);
-    imageView.setImageResource(R.drawable.ic_arrow_forward);
+    imageView.setImageResource(R.drawable.ic_action_forward);
     layout.setEnabled(true);
     layout.setOnClickListener(new View.OnClickListener() {
       @Override
@@ -198,7 +198,7 @@ public void onClick(View v) {
      * textView = (TextView) layout.findViewById(R.id.text1);
      * textView.setText(getString(R.string.manage_dictionary));
      * imageView = (ImageView) layout.findViewById(R.id.image1);
-     * imageView.setImageResource(R.drawable.ic_arrow_forward);
+     * imageView.setImageResource(R.drawable.ic_action_forward);
      */
 
     listView.setAdapter(adapter);
@@ -346,7 +346,7 @@ public View getView(int position, View convertView, ViewGroup parent) {
       }
 
       holder.text.setText(kbd.getResourceName());
-      holder.img.setImageResource(R.drawable.ic_arrow_forward);
+      holder.img.setImageResource(R.drawable.ic_action_forward);
 
       return convertView;
     }

Diff for: android/KMAPro/kMAPro/src/main/java/com/tavultesoft/kmapro/LanguagesSettingsActivity.java

@@ -203,7 +203,7 @@ public View getView(int position, View convertView, ViewGroup parent) {
       }
 
       holder.textLang.setText(data.name);
-      holder.img.setImageResource(R.drawable.ic_arrow_forward);
+      holder.img.setImageResource(R.drawable.ic_action_forward);
 
       holder.textCount.setText(getContext().getResources().getQuantityString(R.plurals.keyboard_count, data.keyboards.size(), data.keyboards.size()));
 

Diff for: android/KMAPro/kMAPro/src/main/java/com/tavultesoft/kmapro/SelectPackageActivity.java

@@ -81,7 +81,7 @@ public void onCreate(Bundle savedInstanceState) {
       HashMap<String, String> hashMap = new HashMap<>();
       hashMap.put(titleKey, keyboardName);
       hashMap.put(subtitleKey, pkgID);
-      String icon = String.valueOf(R.drawable.ic_arrow_forward);
+      String icon = String.valueOf(R.drawable.ic_action_forward);
       hashMap.put(iconKey, icon);
       list.add(hashMap);
     }

Diff for: android/KMAPro/kMAPro/src/main/res/drawable/ic_action_back.xml

@@ -19,11 +19,12 @@
     <ImageButton
       android:id="@+id/back_button"
       style="?android:attr/actionButtonStyle"
+      app:tint="@color/image_button_color"
       android:layout_width="wrap_content"
       android:layout_height="wrap_content"
       android:layout_gravity="start"
       android:contentDescription="@string/label_back"
-      android:src="@drawable/ic_navigation_back" />
+      android:src="@drawable/ic_action_back" />
 
     <ImageButton
       android:id="@+id/forward_button"
@@ -32,7 +33,7 @@
       android:layout_width="wrap_content"
       android:layout_height="wrap_content"
       android:contentDescription="@string/label_forward"
-      android:src="@drawable/ic_navigation_forward" />
+      android:src="@drawable/ic_action_forward" />
 
     <ImageButton
       android:id="@+id/close_button"

Diff for: android/KMAPro/kMAPro/src/main/res/layout/activity_info.xml

@@ -34,7 +34,7 @@
             android:layout_marginEnd="5dp"
             android:layout_weight="1"
             android:contentDescription="@string/image_button"
-            android:src="@drawable/ic_navigation_back" />
+            android:src="@drawable/ic_action_back" />
 
         <ImageButton
             android:id="@+id/forwardButton"
@@ -45,7 +45,7 @@
             android:layout_marginEnd="5dp"
             android:layout_weight="1"
             android:contentDescription="@string/image_button"
-            android:src="@drawable/ic_navigation_forward" />
+            android:src="@drawable/ic_action_forward" />
 
         <ImageButton
             android:id="@+id/bookmarksButton"

Diff for: android/KMAPro/kMAPro/src/main/res/layout/activity_web_browser.xml

@@ -2,4 +2,4 @@
 <ImageView xmlns:android="http://schemas.android.com/apk/res/android"
     android:layout_width="@dimen/preference_icon"
     android:layout_height="@dimen/preference_icon"
-    android:src="@drawable/ic_arrow_forward" />
+    android:src="@drawable/ic_action_forward" />

Diff for: android/KMAPro/kMAPro/src/main/res/layout/preference_icon_layout.xml

@@ -88,7 +88,7 @@ public void onCreate(Bundle savedInstanceState) {
     hashMap = new HashMap<String, String>();
     final String customHelpLink = kbd.getHelpLink();
     // Check if app declared FileProvider
-    String icon = String.valueOf(R.drawable.ic_arrow_forward);
+    String icon = String.valueOf(R.drawable.ic_action_forward);
     // Don't show help link arrow if it's a local help file and File Provider unavailable,
     // or custom help doesn't exist
     if ( (customHelpLink != null && ! KMManager.isTestMode() &&

Diff for: android/KMEA/app/src/main/java/com/keyman/engine/KeyboardInfoActivity.java

@@ -81,7 +81,7 @@ public void onCreate(Bundle savedInstanceState) {
     final String customHelpLink = lm.getHelpLink();
     // Check if app declared FileProvider
     // Currently, model help only available if custom link exists
-    icon = String.valueOf(R.drawable.ic_arrow_forward);
+    icon = String.valueOf(R.drawable.ic_action_forward);
     // Don't show help link arrow if both custom help and File Provider don't exist
     // TODO: Update this when model help available on help.keyman.com
     if ( (!customHelpLink.equals("") && !FileProviderUtils.exists(context)) ||

Diff for: android/KMEA/app/src/main/java/com/keyman/engine/ModelInfoActivity.java

@@ -321,7 +321,7 @@ public View getView(int position, View convertView, ViewGroup parent) {
       //        once it has its own backing Dataset instance.
       // Is this an installed model or not?
 
-      holder.imgDetails.setImageResource(R.drawable.ic_arrow_forward);
+      holder.imgDetails.setImageResource(R.drawable.ic_action_forward);
       if (KeyboardPickerActivity.containsLexicalModel(context, modelKey)) {
         holder.imgInstalled.setImageResource(R.drawable.ic_check);
       } else {

Diff for: android/KMEA/app/src/main/java/com/keyman/engine/ModelPickerActivity.java

@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="utf-8"?>
+<bitmap xmlns:android="http://schemas.android.com/apk/res/android"
+    android:src="@drawable/ic_arrow_back"
+    android:tint="@android:color/black"
+    android:autoMirrored="true" />

Diff for: android/KMEA/app/src/main/res/drawable-hdpi/ic_arrow_back.png

@@ -1,4 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <bitmap xmlns:android="http://schemas.android.com/apk/res/android"
     android:src="@drawable/ic_arrow_forward"
-    android:tint="@color/keyman_blue" />
+    android:tint="@android:color/black"
+    android:autoMirrored="true"/>

Diff for: android/KMEA/app/src/main/res/drawable-mdpi/ic_arrow_back.png

@@ -44,7 +44,7 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:background="@android:color/transparent"
-        android:src="@drawable/ic_arrow_forward"
+        android:src="@drawable/ic_action_forward"
         android:layout_alignParentEnd="true"
         android:layout_centerVertical="true"
         android:layout_marginEnd="12dp"