Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Enable passing a hostname instead of IP #866

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ansasaki
Copy link
Contributor

For the options 'ip', 'contact_ip', and 'registrar_ip', allow a hostname to be used instead of an IP address.

Fixes #848

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 59.72%. Comparing base (2f7b3ad) to head (e535e16).
Report is 58 commits behind head on master.

Files with missing lines Patch % Lines
keylime-agent/src/main.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 59.72% <57.14%> (+2.13%) ⬆️
upstream-unit-tests 59.72% <57.14%> (+8.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
keylime-agent/src/config.rs 74.56% <100.00%> (-12.94%) ⬇️
keylime-agent/src/main.rs 27.23% <0.00%> (+1.21%) ⬆️

... and 8 files with indirect coverage changes

For the options 'ip', 'contact_ip', and 'registrar_ip', allow a hostname
to be used instead of an IP address.

Fixes keylime#848

Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
Copy link
Member

@THS-on THS-on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent contact_ip needs to allow hostnames
4 participants