Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert modules to standardized module system #569

Open
jonkoops opened this issue Feb 3, 2025 · 1 comment · May be fixed by #570
Open

Convert modules to standardized module system #569

jonkoops opened this issue Feb 3, 2025 · 1 comment · May be fixed by #570
Assignees
@jonkoops
Labels
kind/enhancement

Comments

@jonkoops
Copy link
Contributor

jonkoops commented Feb 3, 2025 •
edited
Loading

Currently our code is still using the legacy CommonJS module system, instead standardized ECMAScript modules should be used. This makes the code more familiar to JavaScript developers not familiar with the old module system, and helps future proof the code so that we can upgrade our dependencies.
jonkoops added a commit to jonkoops/keycloak-nodejs-connect that referenced this issue Feb 3, 2025
@jonkoops
Convert modules to standarized ECMAScript
616fb8a 
Closes keycloak#569

Signed-off-by: Jon Koops <[email protected]>
@jonkoops jonkoops linked a pull request Feb 3, 2025 that will close this issue
Draft
@jonkoops jonkoops self-assigned this Feb 4, 2025
jonkoops added a commit to jonkoops/keycloak-nodejs-connect that referenced this issue Feb 5, 2025
@jonkoops
Convert modules to standarized ECMAScript
13dd07a 
Closes keycloak#569

Signed-off-by: Jon Koops <[email protected]>
jonkoops added a commit to jonkoops/keycloak-nodejs-connect that referenced this issue Feb 5, 2025
@jonkoops
Convert modules to standarized ECMAScript
a39d9d5 
Closes keycloak#569

Signed-off-by: Jon Koops <[email protected]>
@jonkoops
Copy link
Contributor Author

jonkoops commented Feb 5, 2025

This will be a breaking change for as long as we support Node.js 18, as it does not have the ability to import standard modules from legacy ones. This issue will have to be resolved when we drop support for Node.js 18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonkoops jonkoops

Labels
kind/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert modules to standarized ECMAScript jonkoops/keycloak-nodejs-connect
1 participant
@jonkoops