Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website "proof just broke" after activating HTTP/2? #1925

Open
davidak opened this issue Dec 17, 2015 · 7 comments
Open

Website "proof just broke" after activating HTTP/2? #1925

davidak opened this issue Dec 17, 2015 · 7 comments

Comments

@davidak
Copy link

davidak commented Dec 17, 2015

My Hoster switched to HTTP/2 today.
My external Monitoring has also Problems with HTTP/2 so this might be also the case here.

I don't get the Proof Link here but i havn't deleted anything from the Webserver.

https://keybase.io/davidak

@mnot
Copy link

mnot commented Dec 20, 2015

I've been on HTTP/2 for a while, and it was fine.

However, the proof did break the day after I updated to Apache 2.4.18. What server are you using?

@davidak
Copy link
Author

davidak commented Dec 21, 2015

@mnot same version ;)

maybe related to this: icing/mod_h2#73

@kgaughan
Copy link

kgaughan commented Jan 4, 2016

Same here. I'm also running Apache 2.4.18, and I experienced the same. To double check, I replaced 'Protocols h2 http/1.1' with 'Protocols http/1.1' in my Apache configuration, and I was able to reverify the site in question.

The funny thing is that, at least going off the logs, Keybase isn't making any http/2 requests, just http/1.1:

54.84.133.185 - - [04/Jan/2016:04:42:00 +0000] "GET / HTTP/1.1" 200 4480 "-" "-"
54.84.133.185 - - [04/Jan/2016:04:42:10 +0000] "GET / HTTP/1.1" 200 4480 "https://stereochro.me/" "-"

Here's what was logged after I switched off http/2:

54.84.133.185 - - [04/Jan/2016:04:43:06 +0000] "GET / HTTP/1.1" 200 4480 "-" "-"
54.84.133.185 - - [04/Jan/2016:04:43:07 +0000] "GET / HTTP/1.1" 200 4480 "https://stereochro.me/" "-"
54.84.133.185 - - [04/Jan/2016:04:43:30 +0000] "GET /.well-known/keybase.txt HTTP/1.1" 200 2049 "-" "keybase-proofs/2.0.46"

The error log revealed nothing particularly enlightening, I'm afraid.

@Sp1l
Copy link

Sp1l commented Jan 10, 2016

This has been fixed in NodeJS Upstream, see nodejs/node@32ac376

Any chance we'll see this in keybase soon? My proof's been broken for quite a while now!

@davidak
Copy link
Author

davidak commented Jan 10, 2016

I got a recovery mail for all my websites yesterday (9.1.16 14:37 CET).

Anybody who has still this problem?

@maxtaco
Copy link
Contributor

maxtaco commented Jan 11, 2016

@Sp1l good to know, thanks for tracking that down. We're running Node 4.2 LTS, and it seems this patch hasn't made it in yet, right? When it's in, we'll upgrade.

@djc
Copy link

djc commented Jan 24, 2016

+1 from me. Also just upgraded to Apache 2.4.18, and had my web identity proof break. I looked at nodejs/node@32ac376 and the latest 4.2 LTS releases, and this does not seem to be in 4.2.4 even though that was released 8 days after this patch landed. Are we sure this is even being tracked for the LTS branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants