Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch dependent optional deps are not included #39

Closed
muffinresearch opened this issue Jun 28, 2023 · 2 comments
Closed

Arch dependent optional deps are not included #39

muffinresearch opened this issue Jun 28, 2023 · 2 comments

Comments

@muffinresearch
Copy link

muffinresearch commented Jun 28, 2023

Hi @kewisch 👋, using the current rev, I'm hitting an error running the action with the action installed as a submodule local to the repo I'm using it from:

Error: Cannot find module '@node-rs/crc32-linux-x64-gnu'

This looks to be due to the arch specific deps not being part of the committed node_modules. A temporary workaround is possible by adding a step which runs npm install like so:

      - name: workaround missing dep in action-web-ext
        working-directory: .github/actions/action-web-ext
        run: npm install
@kewisch
Copy link
Owner

kewisch commented Jun 28, 2023

Hey, thanks for noting. This is some new dependency on yauzl-promise I believe. I really like the lib, but I don't think I am even using the rust feature they include. We should probably either downgrade the lib, or find a different one.

@kewisch
Copy link
Owner

kewisch commented Sep 10, 2024

I have this fixed on main right now by replacing yauzl with jszip, see #51. I have not tagged yet, will do so in a day or two.

@kewisch kewisch closed this as completed Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants