Skip to content

Commit e8ef067

Browse files
committed
Update warning calls to use %s facebook#2870
1 parent c6d1904 commit e8ef067

File tree

5 files changed

+24
-12
lines changed

5 files changed

+24
-12
lines changed

src/browser/ui/dom/CSSPropertyOperations.js

+6-4
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,9 @@ if (__DEV__) {
5151
warnedStyleNames[name] = true;
5252
warning(
5353
false,
54-
'Unsupported style property ' + name + '. Did you mean ' +
55-
camelizeStyleName(name) + '?'
54+
'Unsupported style property %s. Did you mean %s?',
55+
name,
56+
camelizeStyleName(name)
5657
);
5758
};
5859

@@ -64,8 +65,9 @@ if (__DEV__) {
6465
warnedStyleNames[name] = true;
6566
warning(
6667
false,
67-
'Unsupported vendor-prefixed style property ' + name + '. Did you mean ' +
68-
name.charAt(0).toUpperCase() + name.slice(1) + '?'
68+
'Unsupported vendor-prefixed style property %s. Did you mean %s?',
69+
name,
70+
name.charAt(0).toUpperCase() + name.slice(1)
6971
);
7072
};
7173

src/browser/ui/dom/DOMPropertyOperations.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,9 @@ if (__DEV__) {
6161
// logging too much when using transferPropsTo.
6262
warning(
6363
standardName == null,
64-
'Unknown DOM property ' + name + '. Did you mean ' + standardName + '?'
64+
'Unknown DOM property %s. Did you mean %s?',
65+
name,
66+
standardName
6567
);
6668

6769
};

src/classic/element/ReactElement.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,9 @@ function defineWarningProperty(object, key) {
4545
set: function(value) {
4646
warning(
4747
false,
48-
'Don\'t set the ' + key + ' property of the React element. Instead, ' +
49-
'specify the correct value when initially creating the element.'
48+
'Don\'t set the %s property of the React element. Instead, ' +
49+
'specify the correct value when initially creating the element.',
50+
key
5051
);
5152
this._store[key] = value;
5253
}

src/classic/element/ReactElementValidator.js

+6-3
Original file line numberDiff line numberDiff line change
@@ -306,9 +306,12 @@ function warnForPropsMutation(propName, element) {
306306

307307
warning(
308308
false,
309-
'Don\'t set .props.' + propName + ' of the React component' +
310-
elementInfo + '. Instead, specify the correct value when ' +
311-
'initially creating the element.' + ownerInfo
309+
'Don\'t set .props.%s of the React component%s. ' +
310+
'Instead, specify the correct value when ' +
311+
'initially creating the element.%s',
312+
propName,
313+
elementInfo,
314+
ownerInfo
312315
);
313316
}
314317

src/utils/deprecated.js

+6-2
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,12 @@ function deprecated(namespace, oldName, newName, ctx, fn) {
3131
var newFn = function() {
3232
warning(
3333
warned,
34-
`${namespace}.${oldName} will be deprecated in a future version. ` +
35-
`Use ${namespace}.${newName} instead.`
34+
'%s.%s will be deprecated in a future version. ' +
35+
'Use %s.%s instead.',
36+
namespace,
37+
oldName,
38+
namespace,
39+
newName
3640
);
3741
warned = true;
3842
return fn.apply(ctx, arguments);

0 commit comments

Comments
 (0)