Skip to content

Commit 3ef853a

Browse files
committed
feat: tests in parallel
1 parent e32c86f commit 3ef853a

File tree

2 files changed

+23
-36
lines changed

2 files changed

+23
-36
lines changed

gobrew.go

+1-4
Original file line numberDiff line numberDiff line change
@@ -798,10 +798,7 @@ func (gb *GoBrew) getGolangVersions() (result []string) {
798798
func doRequest(url string) (data []byte) {
799799
client := &http.Client{}
800800
request, err := http.NewRequest("GET", url, nil)
801-
if err != nil {
802-
color.Errorln("==> [Error] Cannot create request:", err.Error())
803-
return
804-
}
801+
utils.CheckError(err, "==> [Error] Cannot create request")
805802

806803
request.Header.Set("User-Agent", "gobrew")
807804

gobrew_test.go

+22-32
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import (
1111
)
1212

1313
func TestNewGobrewHomeDirUsesUserHomeDir(t *testing.T) {
14+
t.Parallel()
1415
homeDir, err := os.UserHomeDir()
1516

1617
if err != nil {
@@ -23,13 +24,15 @@ func TestNewGobrewHomeDirUsesUserHomeDir(t *testing.T) {
2324
}
2425

2526
func TestNewGobrewHomeDirDefaultsToHome(t *testing.T) {
27+
t.Parallel()
2628
var envName string
2729

28-
if runtime.GOOS == "windows" {
30+
switch runtime.GOOS {
31+
case "windows":
2932
envName = "USERPROFILE"
30-
} else if runtime.GOOS == "plan9" {
33+
case "plan9":
3134
envName = "home"
32-
} else {
35+
default:
3336
envName = "HOME"
3437
}
3538

@@ -46,6 +49,7 @@ func TestNewGobrewHomeDirDefaultsToHome(t *testing.T) {
4649
}
4750

4851
func TestNewGobrewHomeDirUsesGoBrewRoot(t *testing.T) {
52+
t.Parallel()
4953
oldEnvValue := os.Getenv("GOBREW_ROOT")
5054
defer func() {
5155
_ = os.Setenv("GOBREW_ROOT", oldEnvValue)
@@ -59,6 +63,7 @@ func TestNewGobrewHomeDirUsesGoBrewRoot(t *testing.T) {
5963
}
6064

6165
func TestJudgeVersion(t *testing.T) {
66+
t.Parallel()
6267
tests := []struct {
6368
version string
6469
wantVersion string
@@ -88,8 +93,8 @@ func TestJudgeVersion(t *testing.T) {
8893
version: "1.18@dev-latest",
8994
wantVersion: "1.18.10",
9095
},
91-
// // following 2 tests fail upon new version release
92-
// // commenting out for now as the tool is stable
96+
// following 2 tests fail upon new version release
97+
// commenting out for now as the tool is stable
9398
// {
9499
// version: "latest",
95100
// wantVersion: "1.19.1",
@@ -100,7 +105,9 @@ func TestJudgeVersion(t *testing.T) {
100105
// },
101106
}
102107
for _, test := range tests {
108+
test := test
103109
t.Run(test.version, func(t *testing.T) {
110+
t.Parallel()
104111
gb := NewGoBrew()
105112
version := gb.judgeVersion(test.version)
106113
assert.Equal(t, test.wantVersion, version)
@@ -110,13 +117,15 @@ func TestJudgeVersion(t *testing.T) {
110117
}
111118

112119
func TestListVersions(t *testing.T) {
120+
t.Parallel()
113121
tempDir := t.TempDir()
114122
gb := NewGoBrewDirectory(tempDir)
115123

116124
gb.ListVersions()
117125
}
118126

119127
func TestExistVersion(t *testing.T) {
128+
t.Parallel()
120129
tempDir := t.TempDir()
121130
gb := NewGoBrewDirectory(tempDir)
122131

@@ -126,37 +135,25 @@ func TestExistVersion(t *testing.T) {
126135
}
127136

128137
func TestInstallAndExistVersion(t *testing.T) {
129-
tempDir := filepath.Join(os.TempDir(), "gobrew-test-install-uninstall")
130-
err := os.MkdirAll(tempDir, os.ModePerm)
131-
if err != nil {
132-
t.Skip("could not create directory for gobrew update:", err)
133-
return
134-
}
135-
138+
t.Parallel()
139+
tempDir := t.TempDir()
136140
gb := NewGoBrewDirectory(tempDir)
137141
gb.Install("1.19")
138142
exists := gb.existsVersion("1.19")
139143
assert.Equal(t, true, exists)
140144
}
141145

142146
func TestUnInstallThenNotExistVersion(t *testing.T) {
143-
tempDir := filepath.Join(os.TempDir(), "gobrew-test-install-uninstall")
144-
err := os.MkdirAll(tempDir, os.ModePerm)
145-
if err != nil {
146-
t.Skip("could not create directory for gobrew update:", err)
147-
return
148-
}
149-
defer func() {
150-
_ = os.RemoveAll(tempDir)
151-
}()
152-
147+
t.Parallel()
148+
tempDir := t.TempDir()
153149
gb := NewGoBrewDirectory(tempDir)
154150
gb.Uninstall("1.19")
155151
exists := gb.existsVersion("1.19")
156152
assert.Equal(t, false, exists)
157153
}
158154

159155
func TestUpgrade(t *testing.T) {
156+
t.Parallel()
160157
tempDir := t.TempDir()
161158

162159
gb := NewGoBrewDirectory(tempDir)
@@ -183,6 +180,7 @@ func TestUpgrade(t *testing.T) {
183180
}
184181

185182
func TestDoNotUpgradeLatestVersion(t *testing.T) {
183+
t.Parallel()
186184
t.Skip("skipping test...needs to rewrite")
187185
tempDir := t.TempDir()
188186

@@ -211,16 +209,8 @@ func TestDoNotUpgradeLatestVersion(t *testing.T) {
211209
}
212210

213211
func TestInteractive(t *testing.T) {
214-
tempDir := filepath.Join(os.TempDir(), "gobrew-test-interactive")
215-
err := os.MkdirAll(tempDir, os.ModePerm)
216-
if err != nil {
217-
t.Skip("could not create directory for gobrew update:", err)
218-
return
219-
}
220-
221-
defer func() {
222-
_ = os.RemoveAll(tempDir)
223-
}()
212+
t.Parallel()
213+
tempDir := t.TempDir()
224214

225215
gb := NewGoBrewDirectory(tempDir)
226216
currentVersion := gb.CurrentVersion()

0 commit comments

Comments
 (0)