Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mono Support #16

Open
csainty opened this issue May 21, 2014 · 2 comments
Open

Mono Support #16

csainty opened this issue May 21, 2014 · 2 comments

Comments

@csainty
Copy link

csainty commented May 21, 2014

Is there any interest in making Sigil work on Mono?
I've messed around with it a bit here https://github.com/csainty/Sigil/tree/mono

With some tidy up it is possible to get it building, but there are a number of failing tests.

Some are easy to fix - like this block https://github.com/kevin-montrose/Sigil/blob/master/SigilTests/Add.cs#L73
It seems the Mono Reflection.Emit does some validation, so your this test throws when you attempt to construct an invalid delegate. That section is easily skipped in a Mono build.

Others are more difficult to work out - https://github.com/kevin-montrose/Sigil/blob/master/SigilTests/Add.cs#L54
Mono doesn't seem happy storing the result here back to the &int.

The Add.Overflow test cases are also problematic, I believe because doubles have been used. - https://github.com/kevin-montrose/Sigil/blob/master/SigilTests/Add.cs#L292

There are of course plenty more, I won't try list them all.
Is this a line of investigation worth pursing, or should I just avoid Sigil for xplat?

@kevin-montrose
Copy link
Owner

It would certainly be an improvement if Sigil supported Mono, I haven't tackled it due to lack of time but if you want to take a whack by all means do so.

@csainty
Copy link
Author

csainty commented May 24, 2014

I've set up a mono build on AppVeyor based off my branch so any progress is visible.
This is mono on windows but for now the failures look similar to my local osx build. Can expand to Linux builds once some progress is made generally against the mono runtime.

https://ci.appveyor.com/project/csainty/sigil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants