Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapHover feature not working properly with zonename as an option #14

Open
pcboy opened this issue Jun 14, 2018 · 2 comments
Open

mapHover feature not working properly with zonename as an option #14

pcboy opened this issue Jun 14, 2018 · 2 comments

Comments

@pcboy
Copy link

pcboy commented Jun 14, 2018

Hi,

Looks like something is wrong. When I set the mapHover option to zonename and I hover Asia/Shanghai I can see that America/Chicago is hovered too. They are both labeled as CST but they are different timezones?

@kevalbhatt
Copy link
Owner

@pcboy

U.S. states using CST in the winter and CDT in the summer so JSON which I have it's not dynamic based on time

I am going to make zone abbreviation dynamic in the new release.

So mapHover = zonename will highlights the country which has same zone abbreviation

can you please explain your usecase? so I can understand it better and fix the issue.

@pcboy
Copy link
Author

pcboy commented Jun 18, 2018

It should indeed be CDT in summer. But for me that's not the only problem.
See this screenshot when I hover Shanghai:

image

For me in term of user experience this looks quite strange. Right now time in Chicago is 10:08 PM on June 17th, and time in Shanghai is 11:11AM on June 18th. So even with the hour difference for winter and summer in Chicago, this is still a 12 hours difference? Am I missing something?
Maybe I'm using the wrong option. I tried to use mapHover = 'timezone' instead but that doesn't seem to work. If I hover Paris, Berlin is not in hover mode either while they are both GMT+2.
Basically I'm looking to get something similar to that map when I hover countries:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants