Order history for draws

[jensforsgard]

Bug report

If a draw is agreed upon during the diplomacy phase, then the order history includes an entry for the season in which a draw was agreed, which is a duplicate of the previous season.

Expected behavior

If a draw is agreed upon in a diplomacy phase, then no orders were resolved for that season. The order history tab should not include an entry for that season.

Actual behavior

If a draw is agreed upon in the Diplomacy phase of 1901, then the behavior is as expected. That is, the order history tab has no entries. However, if a draw is agreed upon during the diplomacy phase in any later season, then the order history tab includes a duplicate entry of the last played season (including all phases).

For an example, see gameID=275399. A draw was a greed upon in the Diplomacy phase of Spring 1916. The order history has an entry for Spring 1916, which is a copy of the entry for Autumn 1915 (including adjustment orders).

(If a draw is agreed upon during the Retreat or Adjustments phases, then the behavior is as one would expect.)

Steps to reproduce

Start a game, play at least one phase, and agree to a draw during a diplomacy phase.