Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect ul nesting in Orders page #682

Open
karate opened this issue May 29, 2020 · 0 comments
Open

Incorrect ul nesting in Orders page #682

karate opened this issue May 29, 2020 · 0 comments

Comments

@karate
Copy link
Contributor

karate commented May 29, 2020

Bug report

In the Orders page (/board.php?gameID=XXXXXX&viewArchive=Orders) the ul > li nesting is not correct. ul tags can only have li children, so each nested list should be inside an li tag.

https://developer.mozilla.org/en-US/docs/Learn/HTML/Introduction_to_HTML/HTML_text_fundamentals#Nesting_lists

Fixing this will give us a better structured markup of Rounds / Countries / Phases, and maybe allow for a better UI

Expected behaviour

Nested ul should be inside a parent's li:

<ul>
  <li></li>
  <li>
    <ul>
      <li></li>
    </ul>
  </li>
</ul>

Actual behaviour

Nested ul is placed directly under parent ul:

<ul>
  <li></li>
  <ul>
    <li></li>
  </ul>
</ul>

Steps to reproduce

Open a game and click the Orders link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant