libbpf: Remove unnecessary conversion to bool

kaixuxiakx · kernel-patches-bot · commit 376f2d374d35 · 2020-11-05T23:24:09.000-08:00
Fix following warning from coccinelle:

./tools/lib/bpf/libbpf.c:1478:43-48: WARNING: conversion to bool not needed here

Signed-off-by: Kaixu Xia &lt;kaixuxia@tencent.com&gt;
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
@@ -1475,7 +1475,7 @@ static int set_kcfg_value_tri(struct extern_desc *ext, void *ext_val,
 				ext->name, value);
 			return -EINVAL;
 		}
-		*(bool *)ext_val = value == 'y' ? true : false;
+		*(bool *)ext_val = value == 'y';
 		break;
 	case KCFG_TRISTATE:
 		if (value == 'y')

Original file line number	Diff line number	Diff line change
`@@ -1475,7 +1475,7 @@ static int set_kcfg_value_tri(struct extern_desc ext, void ext_val,`
`1475`	`1475`	`ext->name, value);`
`1476`	`1476`	`return -EINVAL;`
`1477`	`1477`	`}`
`1478`		`- (bool )ext_val = value == 'y' ? true : false;`
	`1478`	`+ (bool )ext_val = value == 'y';`
`1479`	`1479`	`break;`
`1480`	`1480`	`case KCFG_TRISTATE:`
`1481`	`1481`	`if (value == 'y')`