Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching an icon doesn't work anymore #143

Closed
DieEgg opened this issue Feb 27, 2018 · 19 comments
Closed

Searching an icon doesn't work anymore #143

DieEgg opened this issue Feb 27, 2018 · 19 comments

Comments

@DieEgg
Copy link

DieEgg commented Feb 27, 2018

Hi! I love this pllugin, but in the last days I'm getting some issues in using it.

I'm working on a project with the Material Icons set. I'm not able anymore to use the 'search' function when I'm in the grid view (Grid Insert > Material).
I'm noticing that now, whan I insert n icon, the label of its layer is not called for example "material-arrow-forward", but instead "<MOMethod: 0x60800c028640 : target=0x60000ceffe80{ created = 1; id = "arrow_forward"; name = "arrow_forward"; unicode = e82e; }, selector=name> - material".

I've tried to re-install the font, the bundles, the plugin, but nothing changed.
I'll attach two screenshots here :)

screenshot 2018-02-27 13 16 14
screenshot 2018-02-27 13 16 30

@dsuriano
Copy link

dsuriano commented Feb 28, 2018

+1

Investigating a bit further via the Console.app, I'm seeing a new error after attempting to search:

Exception: TypeError: icon.lowercaseString is not a function. (In 'icon.lowercaseString()', 'icon.lowercaseString' is undefined)

Info: {
    column = 35;
    line = 361;
    sourceURL = "/Users/user/Library/Application Support/com.bohemiancoding.sketch3/Plugins/iconfont.sketchplugin/Contents/Sketch/add_all.js";
    stack = "research@/Users/user/Library/Application Support/com.bohemiancoding.sketch3/Plugins/iconfont.sketchplugin/Contents/Sketch/add_all.js:361:35\n/Users/user/Library/Application Support/com.bohemiancoding.sketch3/Plugins/iconfont.sketchplugin/Contents/Sketch/add_all.js:754:49\n[native code]\nonRun@/Users/user/Library/Application Support/com.bohemiancoding.sketch3/Plugins/iconfont.sketchplugin/Contents/Sketch/add_all.js:801:41";
}

Currently on High Sierra v10.13.3
Sketch v49

@rafaRound
Copy link

Same to me.
Currently on El Capitan 10.11.6 and Sketch v49
Any idea what is wrong?
It is weird because other mates doesn't have the same problem

img_2094

@dsuriano
Copy link

dsuriano commented Mar 6, 2018

@keremciu — any ideas as to why this is happening? I'd love to help get this fixed. I tried replacing icon.lowercaseString with icon.toLowerCase() and it just spits back the same error.

@keremciu
Copy link
Owner

keremciu commented Mar 7, 2018

@dsuriano @rafaRound @DieEgg @jeffwain

I will look at this one tonight, it looks like a little one to fix

@dsuriano
Copy link

dsuriano commented Mar 8, 2018

@keremciu Thank you!

@keremciu
Copy link
Owner

@dsuriano @rafaRound @DieEgg I don't know how it's done but it works like a charm rn. I'm using sketch 49.1 and the last version of the plugin

@dsuriano
Copy link

dsuriano commented Mar 26, 2018

@keremciu Using the same and still broken. New console error:

default	15:47:02.209014 -0400	Sketch	Exception: TypeError: icon.indexOf is not a function. (In 'icon.indexOf(q)', 'icon.indexOf' is undefined)
default	15:47:02.209117 -0400	Sketch	Info: {
    column = 27;
    line = 361;
    sourceURL = "/Users/user/Library/Application Support/com.bohemiancoding.sketch3/Plugins/iconfont.sketchplugin/Contents/Sketch/add_all.js";
    stack = "research@/Users/user/Library/Application Support/com.bohemiancoding.sketch3/Plugins/iconfont.sketchplugin/Contents/Sketch/add_all.js:361:27\n/Users/user/Library/Application Support/com.bohemiancoding.sketch3/Plugins/iconfont.sketchplugin/Contents/Sketch/add_all.js:754:49\n[native code]\nonRun@/Users/user/Library/Application Support/com.bohemiancoding.sketch3/Plugins/iconfont.sketchplugin/Contents/Sketch/add_all.js:801:41";
}
default	15:47:02.209218 -0400	Sketch	TypeError: icon.indexOf is not a function. (In 'icon.indexOf(q)', 'icon.indexOf' is undefined)
line: 361
sourceURL: /Users/user/Library/Application Support/com.bohemiancoding.sketch3/Plugins/iconfont.sketchplugin/Contents/Sketch/add_all.js
column: 27
stack: research@/Users/user/Library/Application Support/com.bohemiancoding.sketch3/Plugins/iconfont.sketchplugin/Contents/Sketch/add_all.js:361:27
/Users/user/Library/Application Support/com.bohemiancoding.sketch3/Plugins/iconfont.sketchplugin/Contents/Sketch/add_all.js:754:49
[native code]
onRun@/Users/user/Library/Application Support/com.bohemiancoding.sketch3/Plugins/iconfont.sketchplugin/Contents/Sketch/add_all.js:801:41

@DoortoGate
Copy link

@rafaRound I have the same issue than you. Any updates @keremciu ? Thanks

@rafaRound
Copy link

I formatted my computer, updated the system and reinstalled sketch and plugin; now it works perfectly :)

@DoortoGate
Copy link

haha, that's a hardcore procedure! I will give it a try as well:)

@rafaRound
Copy link

Yes... anyway it was time to to update Mac OSX. Good luck!

@DoortoGate
Copy link

DoortoGate commented Apr 16, 2018

@keremciu Any updates on this? I did everything on my side, and nothing can fix it://

screen shot 2018-04-16 at 09 50 20

@D-Hux
Copy link

D-Hux commented Apr 22, 2018

Been having this same issue as well. Was working prior to sketch 49 update. I thought it was probably just broken with update but recently helped friend install and his works perfect. I tried uninstalling and reinstalling thinking that might help, but NOPE. Any word on this?

@DoortoGate
Copy link

No news so far:/

@keremciu
Copy link
Owner

ops, It's working for me but I'm not sure about why it's not working on your side, are you using sierra? I'm using HighSierra maybe it's related to that?

I will try to find a fix for this one. it looks we need a fallback code there for sierra?

@DoortoGate
Copy link

@keremciu I'm using HighSierra:/ it's really weird. Thank you for helping and providing this amazing product.

@keremciu
Copy link
Owner

@DoortoGate ops, no idea then, do you have any error on console.app?

@jeffwain
Copy link

@keremciu An uninstall/reinstall of the plugin, then adding the SVG version of the (formerly) broken font fixed this for me. On High Sierra.

@oddjones
Copy link

Same problem here - new Mac, fresh install of sketch (v50.2) - is there an open ticket anywhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants