Fix "same" padding torch issue #20270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20270 +/- ##
==========================================
+ Coverage 66.34% 73.41% +7.06%
==========================================
Files 508 511 +3
Lines 48264 48737 +473
Branches 8882 8983 +101
==========================================
+ Hits 32020 35778 +3758
+ Misses 14425 11155 -3270
+ Partials 1819 1804 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks, Sachin. It looks like relevant torch tests are failing, can you take a look? https://github.com/keras-team/keras/actions/runs/10931265787/job/30345878233?pr=20270 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue for all torch layers when used with padding="same" and data_format="channels_first".
This was not caught in any of the test case due to the reason that it only happens with the above condition and when the padding_size is obtained from
_compute_padding_lengthis something like((0,0), (1, 1))Fixes: #20235