-
Notifications
You must be signed in to change notification settings - Fork 309
Default compilation other classifiers #714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default compilation other classifiers #714
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
chenmoneygithub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
PR looks good! there is a formatting issue caused by black version change. Please see the comment above.
| mask_positions, | ||
| mask_ids, | ||
| ) = tf_text.mask_language_model( | ||
| (token_ids, mask_positions, mask_ids,) = tf_text.mask_language_model( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This formatting is due to a black version change. Could you upgrade black and rerun the formatting? Thanks!
mattdangerw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
jbischof
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing. Welcome to KerasNLP @Plutone11011!
Resolve #709
Second commit is due to reformatting