Skip to content

Conversation

@mattdangerw
Copy link
Member

@mattdangerw mattdangerw commented Feb 1, 2023

While debugging our latest nightly failures, I noticed we were downloading a ton of stable tf versions into our nightly image and ultimately installing one.

Switching the nightly requirements file to pull the nightly version of tfds, and avoid keras-tuner entirely (which we no longer use), should avoid this.

@mattdangerw
Copy link
Member Author

mattdangerw commented Feb 1, 2023

Leaving this as a draft while I experiment with the flows on github actions. Will update to a full PR if this seems worth pursuing.

@mattdangerw mattdangerw changed the title Install tfds-nightly for nightly testing Don't install tf stable when building our nightly image Feb 1, 2023
@mattdangerw mattdangerw marked this pull request as ready for review February 1, 2023 22:31
@mattdangerw
Copy link
Member Author

Looks like this can finally turn us green again! Ready for review.

Copy link
Contributor

@jbischof jbischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Green is good!

While debugging our latest nightly failures, I noticed we were
downloading a ton of stable tf versions into our nightly image (and
ultimately installing one).

Switching the nightly requirements file to pull the nightly version of
tfds should avoid this.
@mattdangerw mattdangerw merged commit c35325a into keras-team:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants