Run keras saving tests on nightly and fix RobertaClassifier test #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampathweb
approved these changes
Jan 25, 2023
jbischof
approved these changes
Jan 27, 2023
mattdangerw
force-pushed
the
fix-roberta-saving-test
branch
3 times, most recently
from
52ef32e to
093dbef
Compare
Because of our version comparisons we were not actually running keras saving on nightly CI. This was masking a separate bug where we were not passing `save_format` as a kwarg to `model.save` in the roberta classifier test.
mattdangerw
force-pushed
the
fix-roberta-saving-test
branch
from
093dbef to
c1e97fd
Compare
Member
Author
|
Very interesting, we are facing another issue here, that seems totally core Keras related, where the "new style" Keras testing will only pass on python 3.9. Something related to custom object scope I'm pretty sure we want to keep support python 3.8 to stay in lock step with TF (is that right @sampathweb ?). I'll bump our nightly testing to 3.9 for now, and follow up with Francois and Rick on this next week. |
mattdangerw
added a commit
that referenced
this pull request
Feb 3, 2023
Because of our version comparisons we were not actually running keras saving on nightly CI. This was masking a separate bug where we were not passing `save_format` as a kwarg to `model.save` in the roberta classifier test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of our version comparisons we were not actually running keras saving on nightly CI.
This was masking a separate bug where we were not passing
save_formatas a kwarg tomodel.savein the roberta classifier test.