Add Base Preprocessor Class #638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdangerw
requested changes
Jan 5, 2023
Member
mattdangerw
left a comment
mattdangerw
left a comment
There was a problem hiding this comment.
Looks good! A few coments.
jbischof
reviewed
Jan 6, 2023
Contributor
jbischof
left a comment
jbischof
left a comment
There was a problem hiding this comment.
Thanks @abheesht17 just some small comments! For sanity checking I'd recommend looking at a subclass "from_preset" docstring and running at least one class-level docstring in colab.
jbischof
reviewed
Jan 6, 2023
Contributor
jbischof
left a comment
jbischof
left a comment
There was a problem hiding this comment.
One final concern: how can be make SentencePiece docstring examples runnable?
mattdangerw
approved these changes
Jan 7, 2023
Member
mattdangerw
left a comment
mattdangerw
left a comment
There was a problem hiding this comment.
Just one last comment on my end! LGTM!
jbischof
approved these changes
Jan 9, 2023
Contributor
jbischof
left a comment
jbischof
left a comment
There was a problem hiding this comment.
Amazing work, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #636