From 3584ea4b0f0f8dfd24e962c1b57b549b726c8bef Mon Sep 17 00:00:00 2001 From: Romain Date: Tue, 1 Dec 2015 22:31:53 +0100 Subject: [PATCH] Corrections suggested by Scrutinizer --- Controller/Component/GcmComponent.php | 18 ++++++++---------- Controller/GcmAppController.php | 2 +- 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/Controller/Component/GcmComponent.php b/Controller/Component/GcmComponent.php index 2623128..8512d90 100644 --- a/Controller/Component/GcmComponent.php +++ b/Controller/Component/GcmComponent.php @@ -93,10 +93,9 @@ public function initialize(Controller $controller) { * send method * * @param string|array $ids - * @param array $data + * @param array $payload * @param array $parameters - * @param string $field - * @return void + * @return boolean */ public function send($ids = false, $payload = array(), $parameters = array()) { @@ -149,7 +148,7 @@ public function send($ids = false, $payload = array(), $parameters = array()) { * @param string|array $ids * @param array $notification * @param array $parameters - * @return void + * @return boolean */ public function sendNotification($ids = false, $notification = array(), $parameters = array()) { return $this->send($ids, array('notification' => $notification), $parameters); @@ -161,7 +160,7 @@ public function sendNotification($ids = false, $notification = array(), $paramet * @param string|array $ids * @param array $data * @param array $parameters - * @return void + * @return boolean */ public function sendData($ids = false, $data = array(), $parameters = array()) { return $this->send($ids, array('data' => $data), $parameters); @@ -170,7 +169,7 @@ public function sendData($ids = false, $data = array(), $parameters = array()) { /** * response method * - * @return void + * @return string */ public function response() { if (array_key_exists($this->_response->code, $this->_errorMessages)) { @@ -211,13 +210,12 @@ protected function _executePush($notification = false) { } /** - * _buildNotification method + * _buildMessage method * * @param array $ids - * @param array $data + * @param array $payload * @param array $parameters - * @param string $field - * @return json + * @return false|string */ protected function _buildMessage($ids = false, $payload = false, $parameters = false) { if ($ids === false) { diff --git a/Controller/GcmAppController.php b/Controller/GcmAppController.php index db98558..a4759aa 100644 --- a/Controller/GcmAppController.php +++ b/Controller/GcmAppController.php @@ -8,7 +8,7 @@ class GcmAppController extends AppController { * * @var array */ - public $helpers = array( + public $helpers = array( 'Html', 'Form' );