This repository has been archived by the owner on Jan 19, 2024. It is now read-only.
feat: Update to Keptn 0.14 #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TannerGabriel <[email protected]>
Signed-off-by: TannerGabriel <[email protected]>
Signed-off-by: TannerGabriel <[email protected]>
christian-kreuzberger-dtx
suggested changes
May 17, 2022
There was a problem hiding this comment.
Need to revoke my approval.
Please add
- the secret for unleash
unleash-service/deploy/service.yaml
Lines 29 to 32 in 3485657
Please remove
- deploy/ folder which contains the old chart that should no longer be used
Signed-off-by: TannerGabriel <[email protected]>
|
@christian-kreuzberger-dtx Thanks for the review. I just added the changes. |
|
@TannerGabriel you added the secret to distributor, not the unleash-service. |
Signed-off-by: TannerGabriel <[email protected]>
|
@christian-kreuzberger-dtx Sorry seems like it. It should be fixed now. |
|
The following Docker Images have been built: |
christian-kreuzberger-dtx
pushed a commit
that referenced
this pull request
May 20, 2022
* Use Helm chart and update to Keptn 0.14 Signed-off-by: TannerGabriel <[email protected]> * Update Github actions Signed-off-by: TannerGabriel <[email protected]> * Add build helm chart script Signed-off-by: TannerGabriel <[email protected]> * Remove deploy folder and add environment variable Signed-off-by: TannerGabriel <[email protected]> * Move unleash secret to unleash-service Signed-off-by: TannerGabriel <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
go-utilsto v0.14distributorversion and environment variablesFixes: #73