Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added keploy doc changes for flag --skip-preview #432

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

debayangg
Copy link
Contributor

@debayangg debayangg commented Jul 29, 2024

Pull Request Template

Description

Doc changes for new flag --skip-preview in keploy cli.

Fixes # (issue) Doc Changes for PR #2150

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Additional Context (Please include any Screenshots/gifs if relevant)

...

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added corresponding tests.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in keploy

Copy link
Member

@Sonichigo Sonichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sonichigo Sonichigo merged commit c47e9bc into keploy:main Aug 8, 2024
3 of 5 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 8, 2024
Signed-off-by: Debayan Ghosh <[email protected]>
Signed-off-by: Animesh Pathak <[email protected]>
Co-authored-by: Animesh Pathak <[email protected]>
@debayangg
Copy link
Contributor Author

@Sonichigo this was not the feature that got merged pls see there's another doc changes with this feature merge that instead.

@Sonichigo
Copy link
Member

@Sonichigo this was not the feature that got merged pls see there's another doc changes with this feature merge that instead.

hi @debayangg --disable-line-coverage isn't merged yet that's why i removed since in latest version alpha31 still --skip-preview

@debayangg debayangg deleted the dev_newflag branch August 8, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants