Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no_use_bulkwalkall as an option for discovered devices #766

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

i3149
Copy link
Contributor

@i3149 i3149 commented Oct 18, 2024

Adding a config value to snmp disco to set the no_use_bulkwalkall value for all discovered devices.

Closes #764

When there's a disco config like this

discovery:
    cidrs:
        - 1.2.3.4/28
    ignore_list: []
    debug: false
    ports:
        - 161
    default_communities: []
    use_snmp_v1: false
    default_v3: aws.sm.my-secret-snmp-creds
    add_devices: true
    add_mibs: true
    threads: 4
    replace_devices: true
    check_all_ips: true
    kentik: null
    no_use_bulkwalkall: true

All discovered devices will have no_use_bulkwalkall set to true.

NOTE: if you later on change no_use_bulkwalkall to false in the disco section the discovered devices will continue to have it set to true.

Copy link

@jryburn jryburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@i3149 i3149 merged commit 9417a2f into main Oct 22, 2024
1 check passed
@i3149 i3149 deleted the allow-disco-no-use-bulkwalk branch October 22, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add no_use_bulkwalkall as an option for discovered devices
2 participants