Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow named filters to let multiple rollups hang off one instance #755

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Allow named filters to let multiple rollups hang off one instance #755

merged 2 commits into from
Sep 30, 2024

Conversation

i3149
Copy link
Contributor

@i3149 i3149 commented Sep 28, 2024

Closes #753

Lets filters and rollups work together so that you can attach a named filter to a given set of rollups.

   -filters "string,custom_str.dst_network_bndry,==,external,sum_external"
        -rollups s_sum,sum_external,in_bytes,custom_str.src_subscriber_id

For example.

@i3149 i3149 requested a review from jryburn September 28, 2024 21:45
jryburn
jryburn approved these changes Sep 29, 2024
View reviewed changes
Copy link

@jryburn jryburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@i3149 i3149 merged commit 8371210 into main Sep 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jryburn jryburn jryburn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firehose support for multiple filter and rollups in a single instance
2 participants
@i3149 @jryburn