Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding conversion for DateAndTime ::= TEXTUAL-CONVENTION #696

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Adding conversion for DateAndTime ::= TEXTUAL-CONVENTION #696

merged 1 commit into from
Apr 18, 2024

Conversation

i3149
Copy link
Contributor

@i3149 i3149 commented Apr 17, 2024 •
edited
Loading

Closes #691

Allows hex timestamps to be human readable.

Use the conversion key: hextodatetime for this.

@i3149 i3149 requested a review from thezackm April 17, 2024 20:39
thezackm
thezackm approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@thezackm thezackm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks solid; note that we use epoch timestamps in our back end so if the expectation is to treat this as an actual timestamp and not a string representation, it's not quite there.

@i3149 i3149 merged commit a56f4ab into main Apr 18, 2024
1 check passed
@i3149 i3149 deleted the add-hex-date-time-conv branch April 18, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thezackm thezackm thezackm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DateAndTime - Hex to Timestamp conversion
2 participants
@i3149 @thezackm