Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add no_use_bulkwalkall as an option for discovered devices #764

Closed
araddas opened this issue Oct 17, 2024 · 4 comments · Fixed by #766
Closed

[Feature] Add no_use_bulkwalkall as an option for discovered devices #764

araddas opened this issue Oct 17, 2024 · 4 comments · Fixed by #766
Assignees

Comments

@araddas
Copy link

araddas commented Oct 17, 2024

We have a subset of devices on a specific subnet that do not play nicely with BULKWALK. We would like to add no_use_bulkwalkall: true to all discovered devices, manually defining this parameter per device will not scale within our environment. Ideally we would be able to define this in the discovery or global section, I'm not sure which section makes the most sense, but the following are some examples of how I think it should work.

Possible Discovery Example

discovery:
    cidrs:
        - 1.2.3.4/28
    ignore_list: []
    debug: false
    ports:
        - 161
    default_communities: []
    use_snmp_v1: false
    default_v3: aws.sm.my-secret-snmp-creds
    add_devices: true
    add_mibs: true
    threads: 4
    replace_devices: true
    check_all_ips: true
    kentik: null
    no_use_bulkwalkall: true

Possible Global Example

  global:
    poll_time_sec: 60
    drop_if_outside_poll: false
    mib_profile_dir: /etc/ktranslate/profiles
    mibs_db: /etc/ktranslate/mibs.db
    mibs_enabled: []
    timeout_ms: 20000
    retries: 0
    global_v3: null
    response_time: true
    ping_interval_sec: 60
    no_device_hardcoded_oids: false
    user_tags:
    jitter_time_sec: 0
    fast_poll: false
    watch_profile_changes: false
    save_mds_cache: false
    no_use_bulkwalkall: true
@i3149 i3149 self-assigned this Oct 17, 2024
@i3149
Copy link
Contributor

i3149 commented Oct 18, 2024

Easiest is to define in the discovery section for me. Then this value would get added to discovered devices as the are found. Would you want to further limit its application by subnet? EG, something like:

discovery:
    cidrs:
        - 1.2.3.4/28
    ignore_list: []
    debug: false
    ports:
        - 161
    default_communities: []
    use_snmp_v1: false
    default_v3: aws.sm.my-secret-snmp-creds
    add_devices: true
    add_mibs: true
    threads: 4
    replace_devices: true
    check_all_ips: true
    kentik: null
    no_use_bulkwalkall: 
      - 1.2.3.4/30

Or just keep as a boolean for now?

@araddas
Copy link
Author

araddas commented Oct 18, 2024

I think a boolean would be best for now.

@i3149
Copy link
Contributor

i3149 commented Oct 18, 2024

This does the trick for me in my lab: #766

@i3149
Copy link
Contributor

i3149 commented Oct 22, 2024

Merged in. Only trick I've found is that for devices where no_use_bulkwalkall is true when discovered and then if you subsequently set the disco config to false the device itself keeps no_use_bulkwalkall as true. Assuming this behavior is ok for you but let me know if its trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants