Skip to content

Conversation

@nickserv
Copy link
Contributor

@nickserv nickserv commented Aug 30, 2022

This is a fix for MichaelDeBoey:update-dependencies, so it shouldn't be merged in this repository. I'm just trying to get CI to work as I don't have access to Windows now.

What: use POSIX paths with glob 8 on Windows

Why: glob 8 requires using POSIX paths, even on Windows

How: use path.posix instead of path when using glob

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@nickserv nickserv marked this pull request as draft August 30, 2022 05:17
@nickserv nickserv marked this pull request as ready for review August 30, 2022 05:21
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #232 (7c379c0) into main (01550fe) will not change coverage.
The diff coverage is 87.50%.

@@           Coverage Diff           @@
##             main     #232   +/-   ##
=======================================
  Coverage   63.33%   63.33%           
=======================================
  Files          21       21           
  Lines         600      600           
  Branches      228      227    -1     
=======================================
  Hits          380      380           
  Misses        179      179           
  Partials       41       41           
Impacted Files Coverage Δ
src/config/jest.config.js 92.30% <ø> (ø)
src/config/prettierrc.js 100.00% <ø> (ø)
src/scripts/build/rollup.js 0.00% <0.00%> (ø)
src/config/rollup.config.js 71.11% <100.00%> (-0.63%) ⬇️
src/run-script.js 97.87% <100.00%> (+0.04%) ⬆️
src/utils.js 89.56% <100.00%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nickserv nickserv closed this Aug 30, 2022
@nickserv
Copy link
Contributor Author

See MichaelDeBoey#66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants