Fix bug with cypress testIsolation option
#257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazpearson
approved these changes
Sep 8, 2023
leonardobumbeers
approved these changes
Sep 12, 2023
JamyGolden
force-pushed
the
bugfix/testIsolation
branch
from
3842ba2
to
a34406f
Compare
leonardobumbeers
approved these changes
Sep 13, 2023
leonardobumbeers
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
LGTM! I've faced the same issue when upgrading to version v9.0.0 and still occurs on version v10.0.0
@kentcdodds Could we include this PR in the next release?
kentcdodds
reviewed
Sep 13, 2023
| @@ -37,7 +37,7 @@ function createQuery(queryName, implementationName) { | |||
| Cypress.log({ | |||
| name: queryName, | |||
| type: | |||
| this.get('prev').get('chainerId') === this.get('chainerId') | |||
| this.get('prev')?.get('chainerId') === this.get('chainerId') | |||
There was a problem hiding this comment.
I believe this does the same thing and is more terse :)
|
🎉 This PR is included in version 10.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thank you so much! |
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This fixes a bug where
this.get('prev')returns undefined in some scenarios and the commandthis.get('prev').get('chainerId')throws an error since it's attempting to readgetofundefined.Why:
There is more information about this issue here: #248, but several people have commented that they are experiencing this. @matt-vendia responded with a solution on that issue, which solves the problem for me too (along with others who thumbs-upped the comment).
How:
Make sure
this.get('prev')exists before assuming it's an object.Checklist:
This change is safe and small enough that it is ready to be merged imo.