From 3f078e51939810856f167b87d3d329b6dd7a5cbd Mon Sep 17 00:00:00 2001 From: Brett Daley Date: Mon, 18 Nov 2024 17:44:37 -0500 Subject: [PATCH 1/2] Pass momentum to DQN optimizer --- examples/dqn.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/dqn.py b/examples/dqn.py index 90d8130..4fa9632 100644 --- a/examples/dqn.py +++ b/examples/dqn.py @@ -280,7 +280,7 @@ def dqn(env, replay_off, target_off, output_file_name, store_intermediate_result r_buffer = replay_buffer(REPLAY_BUFFER_SIZE) replay_start_size = REPLAY_START_SIZE - optimizer = optim.RMSprop(policy_net.parameters(), lr=step_size, alpha=SQUARED_GRAD_MOMENTUM, centered=True, eps=MIN_SQUARED_GRAD) + optimizer = optim.RMSprop(policy_net.parameters(), lr=step_size, alpha=SQUARED_GRAD_MOMENTUM, centered=True, eps=MIN_SQUARED_GRAD, momentum=GRAD_MOMENTUM) # Set initial values e_init = 0 From 46b00d9dd3a9361969ce7ff0f4ad1ffb52bf9061 Mon Sep 17 00:00:00 2001 From: Brett Daley Date: Mon, 16 Dec 2024 18:10:55 -0500 Subject: [PATCH 2/2] Delete GRAD_MOMENTUM --- examples/dqn.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/examples/dqn.py b/examples/dqn.py index 4fa9632..f9f9646 100644 --- a/examples/dqn.py +++ b/examples/dqn.py @@ -42,7 +42,6 @@ REPLAY_START_SIZE = 5000 END_EPSILON = 0.1 STEP_SIZE = 0.00025 -GRAD_MOMENTUM = 0.95 SQUARED_GRAD_MOMENTUM = 0.95 MIN_SQUARED_GRAD = 0.01 GAMMA = 0.99 @@ -280,7 +279,7 @@ def dqn(env, replay_off, target_off, output_file_name, store_intermediate_result r_buffer = replay_buffer(REPLAY_BUFFER_SIZE) replay_start_size = REPLAY_START_SIZE - optimizer = optim.RMSprop(policy_net.parameters(), lr=step_size, alpha=SQUARED_GRAD_MOMENTUM, centered=True, eps=MIN_SQUARED_GRAD, momentum=GRAD_MOMENTUM) + optimizer = optim.RMSprop(policy_net.parameters(), lr=step_size, alpha=SQUARED_GRAD_MOMENTUM, centered=True, eps=MIN_SQUARED_GRAD) # Set initial values e_init = 0