Remove unnecessary #[repr(C)] annotations

Author: kelpsyberry

core/src/cpu/interpreter/regs.rs

@@ -4,7 +4,6 @@ use crate::{
     utils::Savestate,
 };
 
-#[repr(C)]
 #[derive(Clone, Debug, Savestate)]
 pub struct Regs {
     pub cur: [u32; 16],

core/src/ds_slot/rom/key1.rs

@@ -1,7 +1,6 @@
 use crate::{cpu::arm7, utils::Bytes};
 
 #[derive(Clone)]
-#[repr(C)]
 pub struct KeyBuffer<const LEVEL_3: bool> {
     key_buf: [u32; 0x412],
     key_code: [u32; 3],

core/src/gpu/engine_3d.rs

@@ -163,7 +163,6 @@ proc_bitfield::bitfield! {
 }
 
 #[derive(Clone, Copy, Debug, PartialEq, Eq, Savestate)]
-#[repr(C)]
 pub struct Polygon {
     pub verts: [VertexAddr; 10],
     pub depth_values: [u32; 10],

core/src/gpu/engine_3d/vertex.rs

@@ -15,7 +15,6 @@ pub type InterpColor = u16x4;
 pub type ScreenCoords = u16x2;
 
 #[derive(Clone, Copy, Debug, PartialEq, Eq, Savestate)]
-#[repr(C)]
 pub struct Vertex {
     pub coords: i32x4,
     pub uv: TexCoords,

core/src/gpu/vram.rs

@@ -27,7 +27,6 @@ proc_bitfield::bitfield! {
     }
 }
 
-#[repr(C)]
 #[derive(Savestate)]
 pub struct Banks {
     pub a: OwnedBytesCellPtr<0x2_0000>,
@@ -41,7 +40,6 @@ pub struct Banks {
     pub i: OwnedBytesCellPtr<0x4000>,
 }
 
-#[repr(C)]
 #[derive(Savestate)]
 struct Map {
     // NOTE: The cells are an ugly hack to avoid macros but also work around simultaneous mutable
@@ -57,7 +55,6 @@ struct Map {
     arm7: [Cell<u8>; 2],
 }
 
-#[repr(C)]
 struct Writeback {
     // NOTE: Same as `Map`
     a_bg: UnsafeCell<[usize; 0x8_0000 / usize::BITS as usize]>,
@@ -77,7 +74,6 @@ pub struct Updates {
     pub oam: bool,             // One 1 KiB (0x400 bytes) region
 }
 
-#[repr(C)]
 #[derive(Savestate)]
 #[load(in_place_only, post = "self.post_load()")]
 #[store(pre = "self.flush_writeback()")]

frontend/desktop/src/audio/input.rs

@@ -11,7 +11,6 @@ use std::{
 
 pub const OUTPUT_SAMPLE_RATE: u32 = SYS_CLOCK_RATE / 128;
 
-#[repr(C)]
 struct Buffer {
     write_pos: AtomicUsize,
     data: Box<UnsafeCell<[i16; MIC_SAMPLES_PER_FRAME * 2]>>,

frontend/desktop/src/audio/output.rs

@@ -19,7 +19,6 @@ pub const DEFAULT_INPUT_SAMPLE_RATE: u32 = SYS_CLOCK_RATE >> 10;
 
 const BUFFER_BASE_CAPACITY: usize = 0x800;
 
-#[repr(C)]
 struct Buffer {
     read_pos: AtomicUsize,
     write_pos: AtomicUsize,

frontend/desktop/src/frame_data.rs

@@ -2,7 +2,6 @@
 use crate::debug_views;
 use dust_core::gpu::Framebuffer;
 
-#[repr(C)]
 pub struct FrameData {
     pub fb: Box<Framebuffer>,
     pub fps: f32,

render/soft-2d/src/threaded/lockstep_scanlines.rs

@@ -22,7 +22,6 @@ use dust_core::{
 };
 use std::{sync::Arc, thread};
 
-#[repr(C)]
 struct Vram<R: Role>
 where
     [(); R::BG_VRAM_LEN]: Sized,
@@ -36,7 +35,6 @@ where
     oam: Bytes<0x400>,
 }
 
-#[repr(C)]
 #[allow(clippy::type_complexity)]
 struct SharedData {
     stopped: AtomicBool,

render/soft-3d/src/data.rs

@@ -7,7 +7,6 @@ use dust_core::{
     utils::Bytes,
 };
 
-#[repr(C)]
 pub struct RenderingData {
     pub control: RenderingControl,
     pub w_buffering: bool,

render/wgpu-2d/src/threaded/lockstep_scanlines.rs

@@ -23,7 +23,6 @@ use dust_core::{
 };
 use std::{sync::Arc, thread};
 
-#[repr(C)]
 struct Vram<R: Role>
 where
     [(); R::BG_VRAM_LEN]: Sized,
@@ -37,7 +36,6 @@ where
     oam: Bytes<0x400>,
 }
 
-#[repr(C)]
 #[allow(clippy::type_complexity)]
 struct SharedData {
     stopped: AtomicBool,

render/wgpu-3d/src/data.rs

@@ -41,7 +41,6 @@ impl GxData {
     }
 }
 
-#[repr(C)]
 pub struct RenderingData {
     pub control: RenderingControl,
 
@@ -120,7 +119,6 @@ impl RenderingData {
     }
 }
 
-#[repr(C)]
 pub struct FrameData {
     pub rendering: RenderingData,
     pub gx: GxData,