-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Invokers] no magic defaults please #906
Comments
I disagree and I think the defaults are an ergonomic win. Less so for video, perhaps, but certainly for dialogs and popovers, where 99% of the time folks are going to want the button to do the intuitive thing (toggle the visibility of the UI).
Could you please expand on what you see is the problem here? The intent behind the proposal is to allow the browser to handle more of the ARIA stuff on your behalf.
You can still have the "magic default" with slightly more CSS: button:is(:not([invokeaction], [invokeaction=auto i]), {
background-color: gold;
} |
Oh I didn't think of those! Kinda makes sense for those, but haven't thought over. I'm just strictly looking at That CSS is valid, but very hard to teach anyone who isn't expert level CSS, & that is not all devs who touch CSS. Again, literal is easier. |
I think we're in agreement on the principle, I can see the point of removing I can't say there's a particularly strong downside to having one. Let's solicit more feedback from people. |
I'm neutral to removing defaults on at least some elements. For one it limits future compatibility issues. But then adding a default in future would potentially have backwards compatability issues so 🤷 I would like to keep a default for at least popover, dialog and details though. |
Just as an FYI I'm implementing this in Chrome atm and won't be implementing the auto behaviour at this time. |
There hasn't been any discussion on this issue for a while, so we're marking it as stale. If you choose to kick off the discussion again, we'll remove the 'stale' label. |
I do not think there should be magic defaults like this. Could be mis-labeled & bad for ARIA, etc.
I'll grab the attention of others in the Video Player field to chime in, but for now I'd like to see:
& then one can CSS:
Otherwise, great proposal!
The text was updated successfully, but these errors were encountered: