New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idea: binary search for ETH tokens #213

Closed

keepkeyjon opened this issue Jan 16, 2020 · 1 comment

Labels

Contributor

keepkeyjon commented Jan 16, 2020

Once we have: keepkey/python-keepkey#88, we could do a binary search here instead of linear: https://github.com/keepkey/keepkey-firmware/blob/master/lib/firmware/ethereum_tokens.c#L22, which would speed up ERC20 signing. This may get more important as the size of the table grows.

Related to #68.

mrnerdhair added the enhancement label

Collaborator

BitHighlander commented Apr 27, 2023

this will be made obsolete by our EV protocol

BitHighlander closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment