Fix issue about removing entry from history and improve logic of history tab showing #9947
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9936
Current deleteIndex() will not remove correspond entry in
m_historyModifications
, then this issue appears.And the current showing logic of history tab is curious. when we perform a modification to an entry and commit it(i.e. click
OK
orApply
). The History Tab will not be showed automatically. we need to reopen the EditEntryWidget. I'm not sure about whether it's a bug, but it's a very small code midification, I bundle it to the related bug fix. Discussions are welcomed.Screenshots
Testing strategy
History
TabType of change